Update Ember to 3.28

[lolmaus]

Updated via pnpx ember-cli-update --to 3.28, followed by a few manual fixes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.08%. Comparing base (94e197a) to head (128f6ae).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         136      136           
  Lines        1016     1016           
=======================================
  Hits          834      834           
  Misses        182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lolmaus]

@kategengler This is ready for review! 🙏

[kategengler]

You've lost behavior here, however -- you can no longer right click -> open in new tab from the results in the typeahead.

[lolmaus]

@kategengler I have reverted that commit and found no other solution to it. The problem is very weird:

When an <a> inside a PowerSelect's <li> is clicked, a hard redirect happens. The action attached to the <a> never fires.

The event target is <a>, while the event handler is attached to the <li>.

My guess is that it's the browser that's causing a hard redirect as it processes the click on <a>. But event.preventDefault() and event.stopPropagation() don't prevent this. :(

It only happens programmatically. I. e. when I replace click() with pauseTest(), click by hand and resume, the test passes.

I worked around the issue by replacing click(find('a')) with click(find('a').parentElement). This is not a good solution as it's not what the user is actually doing. But it happens to resolve the issue, and the issue only happens in test.

If you have any other ideas to fix this, please tell me. One possibility is to upgrade Ember further, maybe it's a regression that has been fixed.

CC @mansona