Skip to content

chore: remove node-sass use sass instead #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: remove node-sass use sass instead #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7e8024
chore: remove node-sass use sass instead
MehulKChaudhari Mar 21, 2025
d2332f3
fix: override node-sass with sass in package.json
MehulKChaudhari Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ember-cli-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const EmberApp = require('ember-cli/lib/broccoli/ember-app');
const envIsProduction = process.env.EMBER_ENV === 'production';
const premberUrls = require('./prember-urls');
const nodeSass = require('node-sass');
const sass = require('sass');

module.exports = function (defaults) {
let app = new EmberApp(defaults, {
Expand All @@ -24,7 +24,7 @@ module.exports = function (defaults) {
generateAssetMap: true,
},
sassOptions: {
implementation: nodeSass,
implementation: sass,
sourceMapEmbed: !envIsProduction,
includePaths: [
'app/styles',
Expand Down
16 changes: 10 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,14 @@
"lodash.uniq": "^4.5.0",
"lodash.values": "^4.3.0",
"minimist": "^1.2.6",
"node-sass": "^9.0.0",
"normalize.css": "^8.0.1",
"npm-run-all": "^4.1.5",
"prember": "^2.1.0",
"prettier": "^2.5.1",
"qunit": "^2.17.2",
"qunit-dom": "^1.6.0",
"sanitize-html": "^2.3.2",
"sass": "^1.86.0",
"semver": "^7.5.4",
"semver-compare": "^1.0.0",
"spawndamnit": "2.0.0",
Expand All @@ -146,8 +146,8 @@
"webpack": "^5.90.0"
},
"engines": {
"node": "16.* || 18.* || 20.*",
"npm": "7 || 8 || >= 9"
"node": "16.* || 18.* || 20.* || >= 22",
"npm": "7 || 8 || 9 || >= 10"
},
"cacheDirectories": [
"node_modules"
Expand All @@ -168,9 +168,13 @@
},
"pnpm": {
"overrides": {
"node-sass": "^9.0.0",
"node-sass": "npm:[email protected].0",
"ember-truth-helpers": "^4.0.0"
}
},
"packageManager": "[email protected]"
}
"packageManager": "[email protected]",
"volta": {
"node": "23.10.0",
"pnpm": "10.6.5"
}
}
Loading