add specific company-phpactor--grab-symbol function #29
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ symbol has to be present in the prefix in order to match phpactor's suggestions. Thus, we need a specific function to extract this prefix.
|
@kermorgant Thanks! |
|
I just came back to my computer to add a comment about lack of testing about my PRs. Well, it's still in alpha so I guess it's not that important :-) |
kermorgant
added a commit
to kermorgant/phpactor.el
that referenced
this pull request
Jul 20, 2018
pr#29 added avriable completion but completion of object methods stopped working. This should now be fixed.
kermorgant
added a commit
to kermorgant/phpactor.el
that referenced
this pull request
Jul 26, 2018
pr#29 added avriable completion but completion of object methods stopped working. This should now be fixed.
zonuexe
added a commit
that referenced
this pull request
Jul 26, 2018
Fix regression from pr #29 causing completion on object to fail
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ symbol has to be present in the prefix in order to match phpactor's
suggestions. Thus, we need a specific function to extract this prefix.
see issue 28