Skip to content

phpactor-move-class does not work #36

@kermorgant

Description

@kermorgant

Invoking function phpactor-move-class ends with the following error

cond: Unknown input type confirm

which stems from

(cl-defun phpactor--action-input-parameters (value-type &key default label choices type)
...
    (cl-case type
      (file (read-file-name label nil default))
      (text (read-string label default))
...
      (t (error "Unknown input type %s" type)))))

I still haven't looked into the details of why value-type has the value "confirm" but I tried to add a condition like this

    (cl-case type
      (confirm (read-string label  default))
      (file (read-file-name label nil default))

with that, I get a confirmation question to which I answered yes. After that, I got this error message

apply: Symbol’s function definition is void: phpactor-action-collection

The *Phpactor input* buffer contains

{
  "action": "collection",
  "parameters": {
    "actions": [
      {
        "name": "close_file",
        "parameters": {
          "path": "/.../AppBundle/Security/Voter/RandomClass1.php"
        }
      },
      {
        "name": "open_file",
        "parameters": {
          "path": "/.../AppBundle/Security/Voter/RandomClass2.php",
          "offset": 0
        }
      }
    ]
  }
}

I'm not sure if my first modification is appropriate, it just happened to make the code run some steps further.

But for sure, we need a phpactor-action-collection function to perform a collection of actions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions