-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support Trio with httpx #3089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support Trio with httpx #3089
Conversation
🔍 Preview links for changed docs |
dependencies = [ | ||
"elastic-transport>=9.1.0,<10", | ||
# TODO revert before merging/releasing | ||
"elastic-transport @ git+https://github.com/pquentin/elastic-transport-python.git@trio-support", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a comment here just to remind you that need this to be edited. (not sure if your TODO
comment triggers some alert or linter...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There's no alert or linter, no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor/optional comments and suggestions, but overall LGTM.
6c42f69
to
e44d3ca
Compare
No description provided.