Skip to content

Control.gtk_motion_notify_event: format to understand it #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Control.gtk_motion_notify_event: format to understand it #2572

wants to merge 1 commit into from
+7 −7

Conversation

tmssngr
Copy link
Contributor

@tmssngr tmssngr commented Oct 1, 2025

The indentation was screwed up, so it was hard to understand the logic.

I also removed the unused assignment to result and the empty else-branch.

Control.gtk_motion_notify_event: format to understand it
d383295 
remove unused code (setting result)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Test Results

  111 files   -  7    111 suites   - 7   11m 29s ⏱️ +22s
4 528 tests  - 55  4 513 ✅  - 34  14 💤  - 22  0 ❌ ±0  1 🔥 +1 
  274 runs   - 56    273 ✅  - 34   1 💤  - 22  0 ❌ ±0 

For more details on these errors, see this check.

Results for commit d383295. ± Comparison against base commit 48e5878.

This pull request removes 56 and adds 1 tests. Note that renamed tests count towards both. 
AllWin32Tests ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromCopiedImage
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
AllWin32Tests TestTreeColumn ‑ test_ColumnOrder
…

org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ Unknown test

@jonahgraham
Copy link
Contributor

@tmssngr the failed test on Windows is something new I introduced and the Windows failure is being investigated in #2568

akurtakov
akurtakov reviewed Oct 2, 2025
View reviewed changes
bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
boolean [] consume = new boolean [1];
if (dragDetect ((int) eventX[0], (int) eventY[0], true, true, consume)) {
dragging = true;
if (consume [0]) result = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line deleted on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because result is not used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please remove "result" variable entirely in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmssngr @jonahgraham @akurtakov