Skip to content

refactor: add note about authentication password #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: add note about authentication password #14

wants to merge 2 commits into from

Conversation

atefBB
Copy link

@atefBB atefBB commented Aug 8, 2018 •
edited
Loading

Hi @dunglas !
#13 DONE.

@atefBB
Copy link
Author

atefBB commented Aug 8, 2018 •
edited
Loading

Hi @dunglas !
I'm wrong about this issue.
In /etc/tor/torrc file, this line should be uncommented:
HashedControlPassword 16:107DFDC...
(the hashed password here, see this https://github.com/DedSecInside/TorBoT/blob/master/Tor.md)

So the code become:

$tc = new TorControl\TorControl(
                array(
                    'hostname'   => '127.0.0.1',
                    'port'       => 9051,
                    'password'   => 'password',
                    // the original password not the hashed one
                    'authmethod' => 1,
                )
            );

Sorry!

@atefBB atefBB closed this Aug 8, 2018
@atefBB atefBB mentioned this pull request Aug 8, 2018
Closed
@atefBB atefBB reopened this Aug 8, 2018
@atefBB
Copy link
Author

atefBB commented Aug 9, 2018 •
edited
Loading

After a digging in control spec, I found:
auth_ctrl_tor

@atefBB
remove close connection statement
bba0037 
This instruction has been called twice for because it always called while the `object destruction` (https://github.com/dunglas/php-torcontrol/blob/master/src/TorControl.php#L136).
dunglas
dunglas requested changes Aug 22, 2018
View reviewed changes
README.md

// Echo the server reply code and message
echo $res[0]['code'].': '.$res[0]['message'];

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

.travis.yml
- 5.5
- 5.6
- 7.0
- hhvm
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to support HHVM. However we should run tests with PHP 7.1 and 7.2.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not touch those files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atefBB @dunglas