Skip to content

This breaks the tests on macOS, so reverting it for now. #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

This breaks the tests on macOS, so reverting it for now. #147

merged 1 commit into from
May 6, 2025

Conversation

mikamikem
Copy link
Collaborator

The macOS browser uses newtab instead of ntp internally, so we need to keep that for consistency across platforms.

aataraxiaa
aataraxiaa approved these changes May 6, 2025
View reviewed changes
Copy link

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikamikem!

@mikamikem mikamikem merged commit 62791eb into main May 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aataraxiaa aataraxiaa aataraxiaa approved these changes

@greyivy greyivy greyivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikamikem @aataraxiaa @greyivy