Clarify some points about Tracker Allowlist #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
reviewed
Nov 22, 2023
| - Tracker allowlist feature in the Privacy Configuration - https://app.asana.com/0/1198207348643509/1199981227466169 | ||
| - Surrogates - https://app.asana.com/0/1198207348643509/1199093921854088/f | ||
|
|
||
| ⚠️ Please note! There are some similarly-named files in this directory. Please |
There was a problem hiding this comment.
I'd skip that, I don't think there would be any confusion here if people read the whole doc and I hope they will. I agree that files are named in a confusing way, but after reading this doc it should be clear.
|
|
||
| ### Privacy config allowlist | ||
|
|
||
| These tests are intended to check correct behaviour of the Tracker Allowlist, |
There was a problem hiding this comment.
Nice work summarizing it in an easy and understandable way 👍
| The Tracker Allowlist is intended as a means of quickly mitigating breakage by | ||
| disabling blocking of particular request patterns, on one or more sites. | ||
|
|
||
| Files in the folder: |
There was a problem hiding this comment.
hm, this "folder" thing seems to add confusion - should we drop it?
I know you'd like to move things to actual folders to make things more clear but that'd require adjusting all implementations so probably not worth it 💀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/0/1206006477979123/f