2. Update Suggestions ranking algorithm; add JSON tests #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checking the tests expectations
<!-- Note: This template is a reminder of our Engineering Expectations and Definition of Done. Remove sections that don't apply to your changes.⚠️ If you're an external contributor, please file an issue before working on a PR. Discussing your changes beforehand will help ensure they align with our roadmap and that your time is well spent. --> Task/Issue URL: https://app.asana.com/0/0/1209533698125405/f Tech Design URL: CC: ### Description ### Testing Steps <!-- Assume the reviewer is unfamiliar with this part of the app --> 1. 2. ### Impact and Risks <!-- What's the impact on users if something goes wrong? High: Could affect user privacy, lose user data, break core functionality Medium: Could disrupt specific features or user flows Low: Minor visual changes, small bug fixes, improvement to existing features None: Internal tooling, documentation --> #### What could go wrong? <!-- Describe specific scenarios and how you've addressed them --> ### Quality Considerations <!-- Focus on what matters for your changes: - What edge cases exist? - How does this affect performance? - What monitoring have you added? - What documentation needs updating? - How does this impact privacy/security? --> ### Notes to Reviewer <!-- Anything specific you want reviewers to focus on --> ### Optional E2E tests**: - [ ] Run macOS PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this. --- ###### Internal references: [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f) | [Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) | [Tech Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Dax Mobile <[email protected]> Co-authored-by: Daniel Bernal <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: kshann <[email protected]> Co-authored-by: Sam Symons <[email protected]> Co-authored-by: Christopher Brind <[email protected]> Co-authored-by: Mariusz Śpiewak <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Sabrina Tardio <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Jacek Łyp <[email protected]> Co-authored-by: Pete Smith <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anh Do <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Fernando Bunn <[email protected]> Co-authored-by: Michal Smaga <[email protected]> Co-authored-by: amddg44 <[email protected]> Co-authored-by: Alessandro Boron <[email protected]> Co-authored-by: Dominik Kapusta <[email protected]> Co-authored-by: Diego Rey Mendez <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Federico Cappelli <[email protected]> Co-authored-by: muodov <[email protected]> Co-authored-by: Graeme Arthur <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Jonathan Kingston <[email protected]> Co-authored-by: Juan Manuel Pereira <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]>
mallexxx
changed the title
tomasstrba
approved these changes
Mar 17, 2025
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
<!-- Note: This template is a reminder of our Engineering Expectations and Definition of Done. Remove sections that don't apply to your changes.⚠️ If you're an external contributor, please file an issue before working on a PR. Discussing your changes beforehand will help ensure they align with our roadmap and that your time is well spent. --> Task/Issue URL: https://app.asana.com/1/137249556945/project/1202406491309510/task/1209377843227194 ### Description - update the suggestions algorithm to match Windows implementation (Show both History record and Open tab: - https://github.com/duckduckgo/windows-browser/blob/ed93effed38cbdd60849629e336345a36731186f/WindowsBrowser.Autocomplete/Services/SuggestionSortAlgorithm.cs - https://github.com/duckduckgo/windows-browser/blob/ed93effed38cbdd60849629e336345a36731186f/WindowsBrowser.Autocomplete/Services/ScoringService.cs - Add JSON Suggestions test scenarios: [`privacy-reference-tests`](https://github.com/duckduckgo/privacy-reference-tests/pull/142/files) - 1st PR of the series with refactoring: #154 ### Testing Steps <!-- Assume the reviewer is unfamiliar with this part of the app --> 1. Activate Internal User from the Debug Menu 2. Activate `autocompleteTabs` override from Debug -> Feature flag overrides menu 3. Open couple of github.com pages, couple of app.asana.com pages and a https://asana.com/resources page, settings, bookmarks, 2 new tabs 4. Switch to the New Tab, start entering `asa`: history record should be autocompleted, one app.asana.com Switch To Tab record should be right after it, asana.com/resources should be below bing results; enter `git` – same (switch to tab suggestion should be either 2nd or at the end of the list 5. Switch to app.asana.com, start entering `app.asa` - validate another app.asana.com is not suggested to switch to, history entry should be suggested; 6. Validate entering `set` suggests to switch to the Settings tab at the bottom, `book` – to the Bookmarks tab. `new` shouldn‘t suggest an open New Tab to switch to. 7. Validate Open Tabs don‘t appear in the Top Hits section ### Quality Considerations <!-- Focus on what matters for your changes: - What edge cases exist? - How does this affect performance? - What monitoring have you added? - What documentation needs updating? - How does this impact privacy/security? --> ### Notes to Reviewer <!-- Anything specific you want reviewers to focus on --> --- ###### Internal references: [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f) | [Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) | [Tech Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Sabrina Tardio <[email protected]> Co-authored-by: Anh Do <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Dax Mobile <[email protected]> Co-authored-by: Daniel Bernal <[email protected]> Co-authored-by: Pete Smith <[email protected]> Co-authored-by: Dominik Kapusta <[email protected]> Co-authored-by: Fernando Bunn <[email protected]> Co-authored-by: Christopher Brind <[email protected]> Co-authored-by: Mariusz Śpiewak <[email protected]> Co-authored-by: muodov <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Diego Rey Mendez <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anka <[email protected]> Co-authored-by: Alessandro Boron <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Elle Sullivan <[email protected]> Co-authored-by: Juan Manuel Pereira <[email protected]> Co-authored-by: Sam Symons <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Jonathan Kingston <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Federico Cappelli <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Graeme Arthur <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Marcos Gurgel <[email protected]> Co-authored-by: Michal Smaga <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: amddg44 <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: bwaresiak <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: shakyShane <[email protected]> Co-authored-by: Shane Osbourne <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Brian Hall <[email protected]> Co-authored-by: Mariusz Śpiewak <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Jacek Łyp <[email protected]> Co-authored-by: Lorenzo Mattei <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Tom Strba <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Kate Manning <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]> Co-authored-by: Anka <[email protected]>
mallexxx
added a commit
to duckduckgo/privacy-reference-tests
that referenced
this pull request
Apr 4, 2025
… the script location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202406491309510/1209499219087615
Privacy Ref Tests PR: duckduckgo/privacy-reference-tests#142
Description
privacy-reference-testsTesting Steps
Activate Internal User from the Debug Menu
Activate
autocompleteTabsoverride from Debug -> Feature flag overrides menuOpen couple of github.com pages, couple of app.asana.com pages and a https://asana.com/resources page, settings, bookmarks, 2 new tabs
Switch to the New Tab, start entering
asa: history record should be autocompleted, one app.asana.com Switch To Tab record should be right after it, asana.com/resources should be below bing results; entergit– same (switch to tab suggestion should be either 2nd or at the end of the listSwitch to app.asana.com, start entering
app.asa- validate another app.asana.com is not suggested to switch to, history entry should be suggested;Validate entering
setsuggests to switch to the Settings tab at the bottom,book– to the Bookmarks tab.newshouldn‘t suggest an open New Tab to switch to.Validate Open Tabs don‘t appear in the Top Hits section
Impact and Risks
What could go wrong?
Quality Considerations
Notes to Reviewer
Optional E2E tests**:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template