Skip to content

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell commented Oct 1, 2025

.slnx files should match the same indentation settings as .csproj and other XML-based project files. This PR adds .slnx to the default .editorconfig template that's used by dotnet new editorconfig.

/cc @baronfel

@lbussell lbussell requested a review from a team as a code owner October 1, 2025 16:50
@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 16:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds .slnx files to the default .editorconfig template to ensure consistent indentation settings across all XML-based project files. The change ensures that new solution files using the .slnx format follow the same 2-space indentation as other XML project files.

  • Adds .slnx to the existing XML project files pattern in .editorconfig
  • Removes trailing whitespace at the end of the file

Copy link
Contributor

github-actions bot commented Oct 1, 2025

This PR is targeting main, which is now for .NET 11-facing work. If you intended to target .NET 10, either retarget this PR to release/10.0.1xx or make sure you backport the change to release/10.0.1xx after merging. See #50394 for more details.

@lbussell
Copy link
Contributor Author

lbussell commented Oct 1, 2025

(force pushed to remove unnecessary whitespace diffs)

@baronfel
Copy link
Member

baronfel commented Oct 1, 2025

@lbussell can you update the template test baselines for the editorconfig template?

@lbussell
Copy link
Contributor Author

lbussell commented Oct 1, 2025

@lbussell can you update the template test baselines for the editorconfig template?

@baronfel is 55819bd what you were looking for?

@lbussell lbussell requested a review from baronfel October 1, 2025 20:17
@marcpopMSFT
Copy link
Member

@baronfel should this be a candidate for GA or just 2xx?

@baronfel
Copy link
Member

baronfel commented Oct 1, 2025

GA would be nice if possible - there was a whole discussion about the editorconfig on .NET Product Chat yesterday that we may want to quickly address.

EDIT: That conversation was about the GitHub-managed VisualStudio editorconfig, not ours, so we're clear to go ahead here.

@baronfel
Copy link
Member

baronfel commented Oct 1, 2025

TBH, this feels so trivially correct and not-breakable to me that it could be tell-mode.

@lbussell
Copy link
Contributor Author

lbussell commented Oct 1, 2025

Repo maintainers, feel free to merge when appropriate.

@baronfel
Copy link
Member

baronfel commented Oct 1, 2025

I'll go ahead and merge to main - we can do a backport for 10 GA next!

@baronfel baronfel merged commit 50f4224 into dotnet:main Oct 1, 2025
27 checks passed
@baronfel
Copy link
Member

baronfel commented Oct 1, 2025

/backport to release/10.0.1xx

Copy link
Contributor

github-actions bot commented Oct 1, 2025

Started backporting to release/10.0.1xx: https://github.com/dotnet/sdk/actions/runs/18176971262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants