-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add .slnx
to default .editorconfig
template
#51082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds .slnx
files to the default .editorconfig
template to ensure consistent indentation settings across all XML-based project files. The change ensures that new solution files using the .slnx
format follow the same 2-space indentation as other XML project files.
- Adds
.slnx
to the existing XML project files pattern in.editorconfig
- Removes trailing whitespace at the end of the file
This PR is targeting |
b13374c
to
b4320d9
Compare
(force pushed to remove unnecessary whitespace diffs) |
@lbussell can you update the template test baselines for the editorconfig template? |
@baronfel should this be a candidate for GA or just 2xx? |
GA would be nice if possible - there was a whole discussion about the editorconfig on .NET Product Chat yesterday that we may want to quickly address. EDIT: That conversation was about the GitHub-managed VisualStudio editorconfig, not ours, so we're clear to go ahead here. |
TBH, this feels so trivially correct and not-breakable to me that it could be tell-mode. |
Repo maintainers, feel free to merge when appropriate. |
I'll go ahead and merge to main - we can do a backport for 10 GA next! |
/backport to release/10.0.1xx |
Started backporting to release/10.0.1xx: https://github.com/dotnet/sdk/actions/runs/18176971262 |
.slnx
files should match the same indentation settings as.csproj
and other XML-based project files. This PR adds.slnx
to the default.editorconfig
template that's used bydotnet new editorconfig
./cc @baronfel