Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
1fa8f16
Support '1.' TFM for CsWinRT 3.0
Sergio0694 Jul 9, 2025
2ad9302
Add 'UsingPreviewCsWinRT3_0Feature' warning
Sergio0694 Jul 9, 2025
c256006
Add test for new preview warning
Sergio0694 Jul 9, 2025
4821072
Run 'msbuild /t:UpdateXlf'
Sergio0694 Jul 9, 2025
aa2210e
Update 'TargetPlatformVersion' parsing
Sergio0694 Jul 15, 2025
ba90d36
Update targeting pack selection logic
Sergio0694 Jul 15, 2025
a6e227a
Update '_WarnForCsWinRT3_0PreviewFeatureEnabled'
Sergio0694 Jul 15, 2025
4d465e6
Define 'CSWINRT3_0' for CsWinRT 3.0
Sergio0694 Jul 16, 2025
676ece8
Add unit tests
Sergio0694 Jul 16, 2025
0c68835
Revert incorrect 'Strings.resx' change
Sergio0694 Jul 22, 2025
58c260c
Update .xlf files
Sergio0694 Jul 22, 2025
d8d8cb0
Fix parsing normalized SDK version
Sergio0694 Jul 22, 2025
fd4f274
Fix framework references creation for '.1' TFM
Sergio0694 Aug 8, 2025
983f973
Add unit tests for normalized defines
Sergio0694 Aug 14, 2025
0e83d36
Merge branch 'main' into user/sergiopedri/cswinrt3-multi-targeting
dsplaisted Aug 14, 2025
b38c092
Switch to using profiles in the same framework reference to different…
dsplaisted Aug 14, 2025
b622290
Add support for WindowsSdkPackageMinimumRevision
dsplaisted Aug 14, 2025
c29c79e
Fix included profiles
manodasanW Aug 15, 2025
415c772
Add CSWinRT 2 and 3 multi-targeting test
dsplaisted Aug 18, 2025
d7126cc
Don't normalize to .0 TargetPlatformVersion revision for CSWinRT 3
dsplaisted Aug 18, 2025
93d669f
Fix profile names
manodasanW Aug 19, 2025
ca298da
Normalize implicit define
manodasanW Aug 19, 2025
95fdd4b
Fix SupportedOSPlatformVersion and tests
manodasanW Aug 19, 2025
0787215
Fix tests and always set EffectiveTargetPlatformVersion
manodasanW Aug 19, 2025
2dffc35
Fix TargetPlatformVersion being set in Directory.Build.targets
manodasanW Aug 20, 2025
ffbdf9e
Apply suggestion from @dsplaisted
manodasanW Aug 20, 2025
8d29560
Fix typo
manodasanW Aug 21, 2025
62fa6b6
Use version parse instead
manodasanW Aug 21, 2025
09e3f53
Add tests and additional error case for WindowsSdkPackageMinimumRevision
dsplaisted Aug 27, 2025
45d1d9b
Collect binlog for test
dsplaisted Sep 4, 2025
0bf81da
Murge upstream changes
dsplaisted Sep 5, 2025
dd54f2a
Copilot implementation of new logic for stage 2 bundled versions
dsplaisted Sep 5, 2025
f615526
Fixup/edits to copilot code
dsplaisted Sep 5, 2025
670d7fc
Remove unnecessary usings
dsplaisted Sep 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Layout/redist/targets/GenerateBundledVersions.targets
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,20 @@ Copyright (c) .NET Foundation. All rights reserved.
TargetingPackVersion="$(NETStandardLibraryRefPackageVersion)"
/>

<!-- Supported Windows versions -->
<!--
Supported Windows versions using CsWinRT 3.0 (.NET 10 is the baseline). This leverages the revision of
the Windows SDK version to allow multi-targeting, which is required to allow customers to gradually migrate.
Both CsWinRT 3.0 and 2.x will be supported for a period of time, and packages can target both of them.
-->
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.26100.1" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_26100PackageVersion)" MinimumNETVersion="10.0" />
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.22621.1" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_22621PackageVersion)" MinimumNETVersion="10.0" />
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.22000.1" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_22000PackageVersion)" MinimumNETVersion="10.0" />
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.20348.1" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_20348PackageVersion)" MinimumNETVersion="10.0" />
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.19041.1" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_19041PackageVersion)" MinimumNETVersion="10.0" />
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.18362.1" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_18362PackageVersion)" MinimumNETVersion="10.0" />
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.17763.1" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_17763PackageVersion)" MinimumNETVersion="10.0" />

<!-- Supported Windows versions using CsWinRT 2.x -->
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.26100.0" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_26100PackageVersion)" MinimumNETVersion="8.0" />
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.22621.0" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_22621PackageVersion)" MinimumNETVersion="8.0" />
<WindowsSdkSupportedTargetPlatformVersion Include="10.0.22000.0" WindowsSdkPackageVersion="$(MicrosoftWindowsSDKNETRef10_0_22000PackageVersion)" MinimumNETVersion="8.0" />
Expand Down
7 changes: 2 additions & 5 deletions src/Layout/redist/targets/OverlaySdkOnLKG.targets
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,8 @@
UseHardLinksIfPossible="true" />

<OverrideAndCreateBundledNETCoreAppPackageVersion
Stage0MicrosoftNETCoreAppRefPackageVersionPath="$(_DotNetHiveRoot)/sdk/$(Stage0SdkVersion)/Microsoft.NETCoreSdk.BundledVersions.props"
MicrosoftNETCoreAppRefPackageVersion="$(MicrosoftNETCoreAppRefPackageVersion)"
NewSDKVersion="$(Version)"
TargetRid="$(TargetRid)"
OutputPath="$(TestHostDotNetRoot)/sdk/$(Version)/Microsoft.NETCoreSdk.BundledVersions.props"/>
Stage0BundledVersionsPath="$(_DotNetHiveRoot)/sdk/$(Stage0SdkVersion)/Microsoft.NETCoreSdk.BundledVersions.props"
Stage2BundledVersionsPath="$(TestHostDotNetRoot)/sdk/$(Version)/Microsoft.NETCoreSdk.BundledVersions.props"/>
</Target>

<Target Name="PublishTestWorkloads"
Expand Down
10 changes: 9 additions & 1 deletion src/Tasks/Common/Resources/Strings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,6 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1225: Native compilation is not supported when invoking the Publish target directly. Try running dotnet publish.</value>
<comment>{StrBegins="NETSDK1225: "}</comment>
</data>
<!-- The latest message added is PrunePackageDataNotFound. Please update this value with each PR to catch parallel PRs both adding a new message -->
<data name="PrunePackageDataNotFound" xml:space="preserve">
<value>NETSDK1226: Prune Package data not found {0} {1} {2}. To ignore this error, set the AllowMissingPrunePackageData to true.</value>
<comment>{StrBegins="NETSDK1226: "}</comment>
Expand All @@ -995,4 +994,13 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1228: This project depends on the Aspire Workload which has been deprecated. Aspire now ships via NuGet packages and no longer requires a workload. Please visit {0} for upgrade guidance.</value>
<comment>{StrBegins="NETSDK1228: "}</comment>
</data>
<data name="UsingPreviewCsWinRT3_0Feature" xml:space="preserve">
<value>NETSDK1229: Targeting a Windows SDK version with '1' as the revision number will reference CsWinRT 3.0, which is currently in preview. The current project is targeting the Windows SDK version '{0}'. If this is not intended, change the revision number to '0' to use CsWinRT 2.x instead.</value>
<comment>{StrBegins="NETSDK1229: "}</comment>
</data>
<data name="CantSpecifyBothProperties" xml:space="preserve">
<value>NETSDK1230: The {0} and {1} properties cannot both be specified. Remove one or the other.</value>
<comment>{StrBegins="NETSDK1230: "}</comment>
</data>
<!-- The latest message added is CantSpecifyBothProperties. Please update this value with each PR to catch parallel PRs both adding a new message -->
</root>
12 changes: 11 additions & 1 deletion src/Tasks/Common/Resources/xlf/Strings.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion src/Tasks/Common/Resources/xlf/Strings.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion src/Tasks/Common/Resources/xlf/Strings.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion src/Tasks/Common/Resources/xlf/Strings.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading