Skip internal tool restore on mac #88877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
jkoritzinsky
approved these changes
Jul 14, 2023
|
Have you tested this one in internal? This one is usually needed to sign, to do swix, and to do IBC stuff which we don't do in-repo. We do sign on macOS, but I think that uses the task and not the restored microbuild dlls. |
hoyosjs
approved these changes
Jul 14, 2023
This was referenced Jul 14, 2023
|
Yup, I ran an official build and signing seemed to proceed just fine. Can't rule out a mistake entirely, but it looked OK to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the Mac internal builds don't consume anything from the internal tools. This looks to be the highest rate rate for build timing out