Skip to content

[browser][ws] fix race condition during message and close events #118887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

[browser][ws] fix race condition during message and close events #118887

merged 1 commit into from
Aug 20, 2025

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Aug 19, 2025 •
edited
Loading

  • delay setting close to receive_status_ptr to not conflict with on-message event
  • fix status for wasm_ws_close_sent

Fixes #117964

@pavelsavara
- delay setting close to receive_status_ptr to not conflict with on-m…
30c067a 
…essage event

- fix status for wasm_ws_close_sent
@pavelsavara pavelsavara added this to the 10.0.0 milestone Aug 19, 2025
@pavelsavara pavelsavara self-assigned this Aug 19, 2025
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Aug 19, 2025
@pavelsavara pavelsavara marked this pull request as ready for review August 20, 2025 07:52
@Copilot Copilot AI review requested due to automatic review settings August 20, 2025 07:52
Copilot
Copilot AI reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a race condition in WebSocket handling between message and close events by introducing proper timing control and status management.

Key changes:

  • Delays the setting of close status to prevent conflicts with on-message events using setTimeout
  • Fixes the WebSocket state logic to properly return CLOSING status when a close has been sent

@pavelsavara pavelsavara merged commit 3376cbd into dotnet:main Aug 20, 2025
37 checks passed
@pavelsavara pavelsavara deleted the browser_ws_close_race branch August 20, 2025 07:54
@pavelsavara
Copy link
Member Author

/backport to release/10.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17233378372

@github-actions github-actions bot mentioned this pull request Aug 26, 2025
Merged
4 tasks
@pavelsavara
Copy link
Member Author

It didn't help, it's still happening in #117964

@pavelsavara pavelsavara mentioned this pull request Sep 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@lewing lewing lewing approved these changes

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[wasm] System.Net.WebSockets.Client.Tests.InvokerCloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose failing with WebSocketException
2 participants
@pavelsavara @lewing