[MONO] Partially revert "Add TypeName APIs to simplify metadata lookup" #118761
+47
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mono specific changes in dotnet#111598 regressed Mono runtime performance significantly. Reverting the changes for now. Fixes dotnet#112763
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR partially reverts Mono-specific changes from a previous TypeName APIs optimization that caused significant performance regressions in the Mono runtime. The revert focuses on removing the extensibleParser parameter and related logic while preserving the core TypeName API functionality.
Key changes:
- Remove
extensibleParserparameter from TypeNameResolver methods - Restore direct RuntimeType.GetType calls for simple overloads
- Revert nested type resolution to use standard GetNestedType method
- Update test expectations for Mono runtime differences
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Type.Mono.cs | Reverts GetType overloads to call RuntimeType.GetType directly for simple cases, removes extensibleParser parameter |
| RuntimeType.Mono.cs | Restores GetNestedType method signature and removes internal ignoreAmbiguousMatch logic |
| TypeNameResolver.Mono.cs | Removes extensibleParser field and simplifies nested type resolution logic |
| TypeTests.cs | Updates test data to account for Mono runtime behavior differences |
src/mono/System.Private.CoreLib/src/System/Reflection/TypeNameResolver.Mono.cs
Outdated
Show resolved
Hide resolved
jkotas
commented
Aug 15, 2025
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Type/TypeTests.cs
Show resolved
Hide resolved
jkotas
commented
Aug 15, 2025
src/mono/System.Private.CoreLib/src/System/Reflection/TypeNameResolver.Mono.cs
Outdated
Show resolved
Hide resolved
jkotas
commented
Aug 15, 2025
jkotas
added
area-System.Reflection
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-reflection |
…time into typename-parsing-perf
AaronRobinsonMSFT
approved these changes
Aug 15, 2025
jonathanpeppers
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
I build this branch locally (Release mode), then copied System.Private.CoreLib.dll on top of my Android runtime pack.
This seems to fix this specific performance regression on Android:
before fix: 1023.8ms
after fix: 907ms
This is pretty close to my estimate from #118747, so looks good. 👍
jonathanpeppers
added a commit
to dotnet/maui
that referenced
this pull request
Aug 15, 2025
I tested this with a "franken-build", using `System.Private.CoreLib.dll` from this PR: * dotnet/runtime#118761 With the `Type.GetType()` revert in place for Mono, I'm getting good startup on an Android Pixel 5 (old) device with the `dotnet new maui` project template: Comparing the updated AOT profile: Before: Average(ms): 624.9 Std Err(ms): 3.77844765302719 Std Dev(ms): 11.9485006032835 After: Average(ms): 582.1 Std Err(ms): 2.92289810519172 Std Dev(ms): 9.24301538099625 Some of my past numbers were on a Pixel 7, so these are good numbers for an even older device. We may want to run this again with newer (less-franken) builds, but this is worth merging for now.
github-actions bot
pushed a commit
to dotnet/maui
that referenced
this pull request
Aug 17, 2025
I tested this with a "franken-build", using `System.Private.CoreLib.dll` from this PR: * dotnet/runtime#118761 With the `Type.GetType()` revert in place for Mono, I'm getting good startup on an Android Pixel 5 (old) device with the `dotnet new maui` project template: Comparing the updated AOT profile: Before: Average(ms): 624.9 Std Err(ms): 3.77844765302719 Std Dev(ms): 11.9485006032835 After: Average(ms): 582.1 Std Err(ms): 2.92289810519172 Std Dev(ms): 9.24301538099625 Some of my past numbers were on a Pixel 7, so these are good numbers for an even older device. We may want to run this again with newer (less-franken) builds, but this is worth merging for now.
rmarinho
pushed a commit
to dotnet/maui
that referenced
this pull request
Aug 18, 2025
I tested this with a "franken-build", using `System.Private.CoreLib.dll` from this PR: * dotnet/runtime#118761 With the `Type.GetType()` revert in place for Mono, I'm getting good startup on an Android Pixel 5 (old) device with the `dotnet new maui` project template: Comparing the updated AOT profile: Before: Average(ms): 624.9 Std Err(ms): 3.77844765302719 Std Dev(ms): 11.9485006032835 After: Average(ms): 582.1 Std Err(ms): 2.92289810519172 Std Dev(ms): 9.24301538099625 Some of my past numbers were on a Pixel 7, so these are good numbers for an even older device. We may want to run this again with newer (less-franken) builds, but this is worth merging for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono specific changes in #111598 regressed Mono runtime performance significantly. Reverting the changes for now.
Fixes #112763