Add NativeAOT on Android tests for Globalization, Interop, and Cryptography #118651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't use BundleDir for android bundle dir: This is PublishDir when TestSingleFile=true (which it is). Android deletes this dir before packaging, deleting the files that were just published. - Don't add the singleFileTestRunner.cs when the test sets IsFunctionalTest=true - Don't run regular nativeaot smoke tests on android yet. - Enable android tests to publish as libs when TestSingleFile=true (default when TestNativeAOT=true)
…/runtime into AndroidAppBuilderNaot
…/runtime into AndroidAppBuilderNaot
There was a problem hiding this comment.
Pull Request Overview
This PR adds NativeAOT support for running System.Globalization.Tests, System.Security.Cryptography.Tests, and System.Runtime.InteropServices.Tests on Android, along with shared MSBuild logic for NativeAOT Android builds.
Key changes include:
- Enhanced monodroid-nativeaot.cs template to support command-line arguments and selective test execution
- Modified build infrastructure to properly handle NativeAOT Android test scenarios
- Added platform-specific test exclusions for unsupported algorithms on Android
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tasks/AndroidAppBuilder/Templates/monodroid-nativeaot.cs | Enhanced to support command-line arguments, JNI array operations, and conditional test execution |
| src/tests/FunctionalTests/Android/Device_Emulator/NativeAOT/Program.cs | Updated Main method signature to accept command-line arguments |
| src/tests/FunctionalTests/Android/Device_Emulator/JIT/Program.cs | Updated Main method signature to accept command-line arguments |
| src/libraries/tests.proj | Added three new test projects to NativeAOT Android smoke tests |
| eng/testing/tests.android.targets | Added NativeAOT-specific build configuration and compile includes |
| src/libraries/System.Security.Cryptography/tests/X509Certificates/TestFiles.cs | Modified test data path resolution to support Android asset directory |
| Multiple cryptography test files | Added Android platform exclusions for unsupported algorithms |
| Build configuration files | Updated MSBuild properties and dependencies for NativeAOT Android builds |
jkotas
reviewed
Aug 12, 2025
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
reviewed
Aug 12, 2025
src/libraries/System.Security.Cryptography/tests/Rfc2898OneShotTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 12, 2025
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run System.Globalization.Tests, System.Security.Cryptography.Tests.csproj, and System.Runtime.InteropServices.Tests on Android with NativeAOT.
Add shared msbuild logic for running NativeAOT on Android.