[MONO] Partially revert "Clean up in Number.Formatting.cs (#110955)" #118499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4020e05.
There was a problem hiding this comment.
Pull Request Overview
This PR partially reverts performance regression introduced in PR #110955 that affected Mono runtime significantly. The changes revert optimizations in number formatting that used ReadOnlySpan<byte> properties back to static readonly byte arrays to restore performance.
- Reverts
TwoDigitsCharsAsBytesandTwoDigitsBytesfromReadOnlySpan<byte>properties back tostatic readonly byte[]fields - Updates references from
MemoryMarshal.GetReferencetoMemoryMarshal.GetArrayDataReferenceto match the reverted field types - Adds
.ToArray()calls to convert the concatenated UTF-8 string literals back to byte arrays
github-actions
bot
added
the
needs-area-label
|
PTAL @stephentoub @lewing |
3 tasks
jkotas
reviewed
Aug 8, 2025
I expect that the rewrite would have to be ifdefed out for Mono as well, to avoid introducing even worse perf regression. |
lewing
approved these changes
Aug 14, 2025
|
Added if-defs, PTAL @jkotas |
This was referenced Aug 15, 2025
jkotas
approved these changes
Aug 15, 2025
|
/ba-g coreclr android timeouts are known and resolved on the tip of main |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in #110955 PR regressed Mono runtime significantly (>150 benchmarks) given number formatting is often a perf sensitive area I'm reverting that change for now, we'll figure out it later in 11.