Skip to content

Conversation

agocke
Copy link
Member

@agocke agocke commented Jul 24, 2025

No description provided.

@agocke agocke requested review from Copilot, VSadov and jkotas and removed request for Copilot July 24, 2025 07:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces compile-time #ifdef FEATURE_RUNTIME_ASYNC preprocessor directives with runtime configuration checks using a new environment variable. This change allows the runtime async feature to be enabled/disabled at runtime rather than requiring recompilation.

Key changes:

  • Replaces #ifdef FEATURE_RUNTIME_ASYNC blocks with runtime CLRConfig::GetConfigValue() checks
  • Adds new UNSUPPORTED_RuntimeAsync configuration value
  • Enables FEATURE_RUNTIME_ASYNC compile definition unconditionally

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/coreclr/vm/methodtablebuilder.cpp Replaces ifdef with runtime config check for method table sizing logic
src/coreclr/vm/method.cpp Replaces ifdef with runtime config check for method return kind classification
src/coreclr/inc/clrconfigvalues.h Adds new RuntimeAsync configuration value definition
src/coreclr/clrdefinitions.cmake Unconditionally enables FEATURE_RUNTIME_ASYNC compile definition

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@agocke agocke enabled auto-merge (squash) July 24, 2025 19:01
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agocke agocke merged commit 1e860a4 into dotnet:main Jul 24, 2025
95 of 97 checks passed
@agocke agocke deleted the async-env branch July 24, 2025 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants