-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Move RuntimeAsync ifdef to env variable #118011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces compile-time #ifdef FEATURE_RUNTIME_ASYNC
preprocessor directives with runtime configuration checks using a new environment variable. This change allows the runtime async feature to be enabled/disabled at runtime rather than requiring recompilation.
Key changes:
- Replaces
#ifdef FEATURE_RUNTIME_ASYNC
blocks with runtimeCLRConfig::GetConfigValue()
checks - Adds new
UNSUPPORTED_RuntimeAsync
configuration value - Enables
FEATURE_RUNTIME_ASYNC
compile definition unconditionally
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
src/coreclr/vm/methodtablebuilder.cpp | Replaces ifdef with runtime config check for method table sizing logic |
src/coreclr/vm/method.cpp | Replaces ifdef with runtime config check for method return kind classification |
src/coreclr/inc/clrconfigvalues.h | Adds new RuntimeAsync configuration value definition |
src/coreclr/clrdefinitions.cmake | Unconditionally enables FEATURE_RUNTIME_ASYNC compile definition |
Tagging subscribers to this area: @mangod9 |
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.