-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[wasi] Disable build in .NET 10 #117936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasi] Disable build in .NET 10 #117936
Conversation
Co-authored-by: maraf <[email protected]>
Tagging subscribers to 'arch-wasm': @lewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables WASI (WebAssembly System Interface) build support and workload usage for .NET 10, aligning with previous changes made for .NET 9. The changes ensure users receive clear error messages when attempting to use unsupported WASI functionality.
Key changes:
- Disables WASI build pipelines in CI/CD configuration
- Removes all WASI-related test jobs from execution
- Adds explicit build failure with informative error message for WASI workload usage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
WorkloadManifest.Wasi.targets.in |
Adds build target that fails with clear error message when WASI runtime identifier is used |
BuildWasiAppsJobsList.txt |
Removes all WASI test jobs, leaving file with only empty line |
eng/pipelines/runtime.yml |
Comments out WASI build template configuration in pipeline |
Comments suppressed due to low confidence (1)
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but merging it now will mean that people who have been using it won't have a way to experiment until we have net11 builds which will take a while. Should we add an env var opt out ?
I guess it's fine to stick to previous preview before there is a .NET 11 preview |
Disables WASI builds and workload usage for .NET 10, similar to the changes made in PR #108877 for .NET 9.
The 'wasi-experimental' workload is not supported in .NET 10. This change makes it explicit, so that users are not misled into thinking that the workload is supported. The WASI experiment continues to be developed but is disabled for this release.
Changes made:
Pipeline changes (
eng/pipelines/runtime.yml
):Test job removal (
eng/testing/scenarios/BuildWasiAppsJobsList.txt
):Workload error target (
WorkloadManifest.Wasi.targets.in
):RuntimeIdentifier
iswasi-wasm
Verification:
Fixes #117931.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.