Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 22, 2025

Disables WASI builds and workload usage for .NET 10, similar to the changes made in PR #108877 for .NET 9.

The 'wasi-experimental' workload is not supported in .NET 10. This change makes it explicit, so that users are not misled into thinking that the workload is supported. The WASI experiment continues to be developed but is disabled for this release.

Changes made:

  1. Pipeline changes (eng/pipelines/runtime.yml):

    • Commented out WASI build targets in MonoAOTOffsets platform matrix
    • Commented out WASI simple-wasm-build-tests template
  2. Test job removal (eng/testing/scenarios/BuildWasiAppsJobsList.txt):

    • Cleared all WASI test jobs from the build job list
  3. Workload error target (WorkloadManifest.Wasi.targets.in):

    • Added build failure target that triggers when RuntimeIdentifier is wasi-wasm
    • Displays clear error message: "The 'wasi-experimental' workload is not supported in .NET 10."

Verification:

  • Normal library builds continue to work correctly
  • WASI-specific CI/CD pipelines are disabled
  • Users attempting to use WASI workload will receive a clear error message

Fixes #117931.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Jul 25, 2025
@maraf maraf added this to the 10.0.0 milestone Jul 25, 2025
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf maraf changed the title [wasi] disable WASI on Net10 and main [wasi] Disable build in .NET 10 Jul 25, 2025
@maraf maraf marked this pull request as ready for review July 25, 2025 09:41
@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 09:41
@maraf maraf requested review from lewing and akoeplinger as code owners July 25, 2025 09:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables WASI (WebAssembly System Interface) build support and workload usage for .NET 10, aligning with previous changes made for .NET 9. The changes ensure users receive clear error messages when attempting to use unsupported WASI functionality.

Key changes:

  • Disables WASI build pipelines in CI/CD configuration
  • Removes all WASI-related test jobs from execution
  • Adds explicit build failure with informative error message for WASI workload usage

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
WorkloadManifest.Wasi.targets.in Adds build target that fails with clear error message when WASI runtime identifier is used
BuildWasiAppsJobsList.txt Removes all WASI test jobs, leaving file with only empty line
eng/pipelines/runtime.yml Comments out WASI build template configuration in pipeline
Comments suppressed due to low confidence (1)

@Copilot Copilot AI requested a review from maraf July 25, 2025 10:02
Copilot finished work on behalf of maraf July 25, 2025 10:02
@maraf maraf enabled auto-merge (squash) July 25, 2025 12:16
@pavelsavara
Copy link
Member

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but merging it now will mean that people who have been using it won't have a way to experiment until we have net11 builds which will take a while. Should we add an env var opt out ?

@maraf maraf merged commit 4580253 into main Jul 28, 2025
159 of 169 checks passed
@jkotas jkotas deleted the copilot/fix-117931 branch July 28, 2025 15:02
@maraf
Copy link
Member

maraf commented Aug 11, 2025

LGTM but merging it now will mean that people who have been using it won't have a way to experiment until we have net11 builds which will take a while. Should we add an env var opt out ?

I guess it's fine to stick to previous preview before there is a .NET 11 preview

@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasi] disable WASI on Net10 and main
4 participants