Escape dashes in RegexCharClass.DescribeSet #117909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the RegexCharClass.DescribeSet method where dashes (-) were not being properly escaped in the output, which could result in invalid or ambiguous character class descriptions. The fix ensures that dashes are properly escaped as \- to avoid confusion with range operators in regex character classes.
Key Changes:
- Added escaping for dash characters in
DescribeCharmethod - Added test case to verify correct escaping behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| RegexCharClass.cs | Added dash character escaping in the DescribeChar method |
| RegexCharClassTests.cs | Added test case to verify dash escaping functionality |
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
AntonLapounov
approved these changes
Jul 22, 2025
MihaZupan
approved these changes
Jul 22, 2025
|
/ba-g timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117637.