Misc cleanup (fixing comments, deleting dead code) #117908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on cleaning up various parts of the CoreCLR codebase by removing dead code, fixing comments, and simplifying configurations. The changes primarily involve removing obsolete code paths, correcting comment inaccuracies, and eliminating unused functionality.
- Removes dead code including unused function declarations, obsolete conditional compilation blocks, and unnecessary attributes
- Fixes and updates comments to reflect current implementation details more accurately
- Simplifies build configurations by removing obsolete defines and reorganizing file lists
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/nativeaot/SmokeTests/PInvoke/PInvoke.cs | Removes unused __BlockAllReflectionAttribute class definition |
| src/coreclr/vm/runtimehandles.h | Removes unused CanCastToInternal function declaration |
| src/coreclr/vm/eedbginterface.h | Removes unused HashMapEnumCallback typedef |
| src/coreclr/utilcode/loaderheap.cpp | Removes obsolete comments about synchronization and interleaved heap behavior |
| src/coreclr/utilcode/interleavedloaderheap.cpp | Updates comments to remove redundant "interleaved heap" references |
| src/coreclr/utilcode/explicitcontrolloaderheap.cpp | Removes obsolete synchronization comment |
| src/coreclr/utilcode/allocmemtracker.cpp | Removes unnecessary DACCESS_COMPILE conditional compilation block |
| src/coreclr/utilcode/CMakeLists.txt | Moves allocmemtracker.cpp from common sources to specific sources list |
| src/coreclr/tools/aot/ILCompiler.MetadataTransform/ILCompiler.MetadataTransform.csproj | Removes obsolete NETFX_45 define |
| src/coreclr/tools/Common/Internal/NativeFormat/NativeFormatReader.String.cs | Removes obsolete .NET Framework 4.5 compatibility code |
| src/coreclr/tools/Common/Internal/Metadata/NativeFormat/NativeMetadataReader.cs | Removes obsolete TODO comment about metadata schema signature |
| src/coreclr/jit/importercalls.cpp | Fixes log message and removes obsolete architecture-specific comment |
| src/coreclr/inc/palclr.h | Removes unused PAL exception handling macros and compiler instance abstractions |
| src/coreclr/inc/loaderheap.h | Corrects various comment inaccuracies about function names and heap purposes |
| docs/workflow/requirements/windows-requirements.md | Updates documentation to remove ARM32 references, focusing only on ARM64 |
github-actions
bot
added
the
needs-area-label
jkotas
commented
Jul 22, 2025
jkotas
commented
Jul 22, 2025
jkotas
commented
Jul 22, 2025
src/coreclr/tools/Common/Internal/Metadata/NativeFormat/NativeMetadataReader.cs
Show resolved
Hide resolved
jkotas
commented
Jul 22, 2025
AaronRobinsonMSFT
approved these changes
Jul 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.