Skip to content

Replace Assert.NotNull with Assert.Empty in AsyncEnumerable SequenceTests #117821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2025
Merged

Replace Assert.NotNull with Assert.Empty in AsyncEnumerable SequenceTests #117821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a502e65
Initial plan
Copilot Jul 18, 2025
01ca63c
Replace Assert.NotNull with Assert.Empty in AsyncEnumerable SequenceT…
Copilot Jul 18, 2025
5ed6fdd
Replace Assert.NotNull with appropriate assertions for AsyncEnumerabl…
Copilot Jul 18, 2025
1496c27
Fix Assert.NotNull issues in System.Linq SequenceTests
Copilot Jul 19, 2025
af31809
Merge branch 'main' into copilot/fix-a51be19a-3d17-4f18-a60d-5ebc53f2…
stephentoub Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/libraries/System.Linq.AsyncEnumerable/tests/SequenceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,25 +51,28 @@ static void ValidateSigned<T>() where T : INumber<T>
{
ValidateUnsigned<T>();

for (int i = 1; i < 3; i++)
{
Assert.NotNull(AsyncEnumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(122), T.CreateTruncating(-i)));
}
// Test negative steps from 123 to 122
// step=-1: should give [123, 122] (2 elements)
// step=-2: should give [123] (1 element, step too large)
Assert.Equal(2, AsyncEnumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(122), T.CreateTruncating(-1)).CountAsync().Result);
Assert.Single(AsyncEnumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(122), T.CreateTruncating(-2)));

ValidateThrows(T.CreateTruncating(123), T.CreateTruncating(124), T.CreateTruncating(-2));
}

static void ValidateUnsigned<T>() where T : INumber<T>
{
// When start == end, all steps should return single element [123]
for (int i = 0; i < 3; i++)
{
Assert.NotNull(AsyncEnumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(123), T.CreateTruncating(i)));
Assert.Single(AsyncEnumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(123), T.CreateTruncating(i)));
}

for (int i = 1; i < 3; i++)
{
Assert.NotNull(AsyncEnumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(124), T.CreateTruncating(i)));
}
// Test positive steps from 123 to 124
// step=1: should give [123, 124] (2 elements)
// step=2: should give [123] (1 element, step too large)
Assert.Equal(2, AsyncEnumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(124), T.CreateTruncating(1)).CountAsync().Result);
Assert.Single(AsyncEnumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(124), T.CreateTruncating(2)));

ValidateThrows(T.CreateTruncating(123), T.CreateTruncating(122), T.CreateTruncating(2));
}
Expand Down
21 changes: 12 additions & 9 deletions src/libraries/System.Linq/tests/SequenceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,25 +50,28 @@ static void ValidateSigned<T>() where T : INumber<T>
{
ValidateUnsigned<T>();

for (int i = 1; i < 3; i++)
{
Assert.NotNull(Enumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(122), T.CreateTruncating(-i)));
}
// Test negative steps from 123 to 122
// step=-1: should give [123, 122] (2 elements)
// step=-2: should give [123] (1 element, step too large)
Assert.Equal(2, Enumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(122), T.CreateTruncating(-1)).Count());
Assert.Single(Enumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(122), T.CreateTruncating(-2)));

ValidateThrows(T.CreateTruncating(123), T.CreateTruncating(124), T.CreateTruncating(-2));
}

static void ValidateUnsigned<T>() where T : INumber<T>
{
// When start == end, all steps should return single element [123]
for (int i = 0; i < 3; i++)
{
Assert.NotNull(Enumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(123), T.CreateTruncating(i)));
Assert.Single(Enumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(123), T.CreateTruncating(i)));
}

for (int i = 1; i < 3; i++)
{
Assert.NotNull(Enumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(124), T.CreateTruncating(i)));
}
// Test positive steps from 123 to 124
// step=1: should give [123, 124] (2 elements)
// step=2: should give [123] (1 element, step too large)
Assert.Equal(2, Enumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(124), T.CreateTruncating(1)).Count());
Assert.Single(Enumerable.Sequence(T.CreateTruncating(123), T.CreateTruncating(124), T.CreateTruncating(2)));

ValidateThrows(T.CreateTruncating(123), T.CreateTruncating(122), T.CreateTruncating(2));
}
Expand Down
Loading