[cDAC] Exclude cDAC changes from unrelated pipeline conditions #116835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default path evaluation to exclude cDAC changes from most pipeline subsets while ensuring the tools_cdac subset includes both the cDAC directory and the coreclr runtimeinfo paths.
- Exclude
src/native/managed/cdac/*frommono_excluding_wasm,coreclr,libraries, andinstallerjob triggers - Add
src/coreclr/debug/runtimeinfo/*alongsidesrc/native/managed/cdac/*in thetools_cdacsubset include list
Comments suppressed due to low confidence (1)
eng/pipelines/common/evaluate-default-paths.yml:97
- [nitpick] The
src/native/managed/cdac/*exclusion is repeated across multiple job definitions. Consider extracting common exclude patterns into a YAML anchor or variable to reduce duplication and simplify future updates.
- src/native/managed/cdac/*
jkoritzinsky
approved these changes
Jun 19, 2025
hoyosjs
approved these changes
Jun 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
coreclrsrc/native/managed/cdac/*mono_excluding_wasmsrc/native/managed/cdac/*librariessrc/native/managed/cdac/*installersrc/native/managed/cdac/*tools_cdacsrc/coreclr/debug/runtimeinfo/*(datadescriptors)