Fix DAC-ification of the InterpreterFrame::SetContextToInterpMethodContextFrame #116797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntextFrame There is an incorrect cast of `this` to TADDR that was resulting in the DAC side address being stored in the context. That was leading to an assert in the stack walking code on the DAC side that was crashing WinDbg. This change replaces C-style cast with the proper dac_cast.
There was a problem hiding this comment.
Pull Request Overview
Fixes incorrect DAC-side address being stored in the interpreter frame context by replacing a C-style cast with the proper dac_cast.
- Replaces
(TADDR)thiswithdac_cast<TADDR>(this)inSetFirstArgRegto ensure correct DAC address translation.
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
approved these changes
Jun 18, 2025
jkotas
approved these changes
Jun 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an incorrect cast of
thisto TADDR that was resulting in the DAC side address being stored in the context. That was leading to an assert in the stack walking code on the DAC side that was crashing WinDbg.This change replaces C-style cast with the proper dac_cast.