Skip to content

Make HttpStress fail on unobserved exceptions #115849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Make HttpStress fail on unobserved exceptions #115849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/libraries/System.Net.Http/tests/StressTests/HttpStress/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,12 +244,20 @@ private static async Task<ExitCode> Run(Configuration config)
}

// return nonzero status code if there are stress errors
return client?.TotalErrorCount == 0 ? ExitCode.Success : ExitCode.StressError;
return client?.TotalErrorCount == 0 && s_unobservedExceptions.Count == 0 ? ExitCode.Success : ExitCode.StressError;
}

private static void PrintUnobservedExceptions()
{
if (s_unobservedExceptions.Count == 0)
{
Console.WriteLine("No unobserved exceptions detected.");
return;
}

Console.ForegroundColor = ConsoleColor.DarkRed;
Console.WriteLine($"Detected {s_unobservedExceptions.Count} unobserved exceptions:");
Console.ResetColor();

int i = 1;
foreach (KeyValuePair<string, int> kv in s_unobservedExceptions.OrderByDescending(p => p.Value))
Expand Down
Loading