Skip to content

[release/9.0-staging] [DNS] Ignore ObjectDisposedException on CancellationToken Callback #115840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2025
Merged

[release/9.0-staging] [DNS] Ignore ObjectDisposedException on CancellationToken Callback #115840

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5eaf9c1
Ignore ObjectDisposedException on CancellationToken Callback
liveans May 20, 2025
66a76c1
Update src/libraries/System.Net.NameResolution/src/System/Net/NameRes…
liveans May 20, 2025
1398eb9
Change wording in comment
liveans May 20, 2025
773ed99
Update src/libraries/System.Net.NameResolution/src/System/Net/NameRes…
jkotas May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,11 @@ public void RegisterForCancellation(CancellationToken cancellationToken)
NetEventSource.Info(@this, $"GetAddrInfoExCancel returned error {cancelResult}");
}
}
catch (ObjectDisposedException)
{
// There is a race between checking @this._completed and @this.DangerousAddRef and disposing from another thread.
// We lost the race. No further action needed.
}
finally
{
if (needRelease)
Expand Down
Loading