Skip to content

MSBUILD Server dogfood #115766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 19, 2025
Merged

MSBUILD Server dogfood #115766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0364fa6
updating based on review with Jemery Koritzinsky
SimaTian Sep 16, 2025
44e0617
Clean up environment variable definitions
SimaTian Sep 17, 2025
38baf74
adding an escape hatch for the dogfood
SimaTian Sep 17, 2025
c7de44d
Merge branch 'MSBUILD-dogfood' of https://github.com/dotnet/runtime i…
SimaTian Sep 17, 2025
ca95726
minor cleanup
SimaTian Sep 17, 2025
c6cdf38
Fix environment variable name for MSBuild server
SimaTian Sep 17, 2025
a30328e
affordance for old powershell
SimaTian Sep 17, 2025
ebb9eb4
Merge branch 'MSBUILD-dogfood' of https://github.com/dotnet/runtime i…
SimaTian Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions eng/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,16 @@ if ($vs) {
# Disable .NET runtime signature validation errors which errors for local builds
$env:VSDebugger_ValidateDotnetDebugLibSignatures=0;

# MSBuild Server dogfood.
if ($env:DOTNET_CLI_USE_MSBUILD_SERVER -eq $null)
{
$env:DOTNET_CLI_USE_MSBUILD_SERVER = 1
}
if ($env:MSBUILDUSESERVER -eq $null)
{
$env:MSBUILDUSESERVER = 1
}

# Respect the RuntimeConfiguration variable for building inside VS with different runtime configurations
if ($runtimeConfiguration)
{
Expand Down
4 changes: 4 additions & 0 deletions eng/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ while [[ -h "$source" ]]; do
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"

# MSBuild Server dogfood.
export MSBUILDUSESERVER="${MSBUILDUSESERVER:-1}"
export DOTNET_CLI_USE_MSBUILD_SERVER="${DOTNET_CLI_USE_MSBUILD_SERVER:-1}"

usage()
{
echo "Common settings:"
Expand Down
4 changes: 4 additions & 0 deletions eng/pipelines/common/global-build-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ jobs:
- ${{ format('build_{0}{1}_{2}_{3}_{4}', parameters.osGroup, parameters.osSubgroup, parameters.archType, coalesce(globalBuild.buildConfig, parameters.buildConfig), globalBuild.nameSuffix) }}

variables:
- name: "MSBUILDUSESERVER"
value: "1"
- name: "DOTNET_CLI_USE_MSBUILD_SERVER"
value: "1"
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- group: DotNet-HelixApi-Access
- group: AzureDevOps-Artifact-Feeds-Pats
Expand Down
3 changes: 3 additions & 0 deletions eng/pipelines/common/templates/global-build-step.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ parameters:
steps:
- script: $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci ${{ parameters.archParameter }} $(_osParameter) ${{ parameters.crossArg }} ${{ parameters.buildArgs }} ${{ parameters.targetCxxLibraryConfigurationArgs }} $(_officialBuildParameter) $(_overrideTestScriptWindowsCmdParameter)
displayName: ${{ parameters.displayName }}
env:
MSBUILDUSESERVER: '1'
DOTNET_CLI_USE_MSBUILD_SERVER: '1'
${{ if eq(parameters.useContinueOnErrorDuringBuild, true) }}:
continueOnError: ${{ parameters.shouldContinueOnError }}
${{ if ne(parameters.container, '') }}:
Expand Down
3 changes: 3 additions & 0 deletions eng/pipelines/global-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ extends:
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true),
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_non_mono_and_wasm.containsChange'], true),
eq(variables['isRollingBuild'], true))
env:
MSBUILDUSESERVER: 1
DOTNET_CLI_USE_MSBUILD_SERVER: 1

#
# Build with RuntimeFlavor only. This exercise code paths where only RuntimeFlavor is
Expand Down
Loading