Skip to content

Remove redundant 'freeList' field from HashLookup class #114914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Remove redundant 'freeList' field from HashLookup class #114914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/Utils/HashLookup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ internal sealed class HashLookup<TKey, TValue>
private int[] buckets;
private Slot[] slots;
private int count;
private int freeList;
private readonly IEqualityComparer<TKey>? comparer;

private const int HashCodeMask = 0x7fffffff;
Expand All @@ -36,7 +35,6 @@ internal HashLookup(IEqualityComparer<TKey>? comparer)
this.comparer = comparer;
buckets = new int[7];
slots = new Slot[7];
freeList = -1;
}

// If value is not in set, add it and return true; otherwise return false
Expand Down Expand Up @@ -97,18 +95,10 @@ private bool Find(TKey key, bool add, bool set, [MaybeNullWhen(false)] ref TValu

if (add)
{
int index;
if (freeList >= 0)
{
index = freeList;
freeList = slots[index].next;
}
else
{
if (count == slots.Length) Resize();
index = count;
count++;
}
if (count == slots.Length) Resize();

int index = count;
count++;

int bucket = hashCode % buckets.Length;
slots[index].hashCode = hashCode;
Expand Down
Loading