-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add ability to raise AppDomain.UnhandledException
event.
#114392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to raise AppDomain.UnhandledException
event.
#114392
Conversation
Add new API for all runtimes. Add tests for all runtimes.
Note regarding the
|
1 similar comment
Note regarding the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/tests/baseservices/exceptions/RaiseUnhandledExceptionEvent/RaiseEvent.csproj: Language not supported
Comments suppressed due to low confidence (1)
src/coreclr/vm/metasig.h:361
- [nitpick] The new meta-signature for returning bool is introduced without additional context. Consider adding a clarifying comment explaining its intended usage and how it differs from similar meta-signatures to improve overall code clarity.
DEFINE_METASIG(SM(Obj_RetBool, j, F))
Tagging subscribers to this area: @dotnet/area-system-runtime |
src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionHandling.cs
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]>
src/tests/baseservices/exceptions/RaiseUnhandledExceptionEvent/RaiseEvent.cs
Outdated
Show resolved
Hide resolved
Update tests based on new API name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/ba-g Unable to get logs for the failing tests, but they don't seem related given the details I see on AzDO. |
This API is primarily for use in interop scenarios where the .NET runtime is hosted and an unhandled exception is detected by the hosting runtime. See #102730 for additional details.
Fixes #102730