Skip to content

Sign and harden pkgs #114027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 2, 2025
Merged

Sign and harden pkgs #114027

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bea1e95
Sign and harden pkgs
mmitche Mar 28, 2025
9867f76
Fix missing closing quote in MacOSPkg element
mmitche Mar 28, 2025
594f5d1
Add singlefilehost to MacOS signing list
mmitche Mar 31, 2025
b4241dd
Add new executables to MacOS signing list
mmitche Apr 1, 2025
30fef8c
Add 'Mono' to MacOS signing list
mmitche Apr 1, 2025
086b46d
Remove inadvertently added lines
akoeplinger Apr 1, 2025
34cdc8b
Merge branch 'main' into sign-and-harden-pkgs
mmitche Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,12 @@
<FileSignInfo Include="mscordaccore.dll" CertificateName="None" />
<FileSignInfo Include="mscordbi.dll" CertificateName="None" />

<!-- On MacOS, we need to sign a number of our executables with the Mac developer cert with hardening enabled. -->
<FileSignInfo Condition="'$(TargetsOSX)' == 'true'" Include="dotnet;apphost;corerun;createdump" CertificateName="MacDeveloperHarden" />
<!-- On MacOS, we need to sign a number of our executables with the Mac developer cert with hardening enabled.
Avoid doing this on Linux, which has the same executable names -->
<FileSignInfo Condition="'$(TargetsOSX)' == 'true'" Include="dotnet;apphost;corerun;createdump;singlefilehost;crossgen2;ilasm;ilc;ildasm;llc;mono-aot-cross;opt;Mono" CertificateName="MacDeveloperHarden" />
<!-- Additionally, we need to notarize any .pkg files -->
<MacOSPkg Include="$(ArtifactsPackagesDir)**/dotnet-runtime*.pkg" Exclude="$(ArtifactsPackagesDir)**/dotnet-runtime-internal*.pkg" />
<FileSignInfo Include="@(MacOSPkg->'%(Filename)%(Extension)')" CertificateName="MacDeveloperWithNotarization" />

<!-- We don't need to code sign .js files because they are not used in Windows Script Host. -->
<!-- WARNING: Needs to happed outside of any target -->
Expand Down
Loading