Skip to content

[browser] Marshalling of resolved Tasks/promises is not resolved in JS/C# #105464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2024
Merged

[browser] Marshalling of resolved Tasks/promises is not resolved in JS/C# #105464

merged 3 commits into from
Aug 1, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 25, 2024 •
edited
Loading

The PR solves the problem with void Task marshalling. Fixes #104772.

cc @pavelsavara

Might be connected: #95411

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Jul 25, 2024
@ilonatommy ilonatommy self-assigned this Jul 25, 2024
@pavelsavara
Copy link
Member

WBT is too heavy weight integration test for this. Let's add test to src\libraries\System.Runtime.InteropServices.JavaScript\tests\System.Runtime.InteropServices.JavaScript.UnitTests\System\Runtime\InteropServices\JavaScript\JSImportTest.cs instead

This was referenced Jul 29, 2024
Open
Closed
Open
@ilonatommy
Copy link
Member Author

ilonatommy commented Jul 29, 2024 •
edited
Loading

ST

MT JSImport

MT JSExport - disabled, re-run with update.

@build-analysis build-analysis bot mentioned this pull request Jul 29, 2024
Open
This was referenced Jul 30, 2024
Closed
Open
@ilonatommy ilonatommy marked this pull request as ready for review July 31, 2024 09:04
@ilonatommy ilonatommy requested a review from lewing as a code owner July 31, 2024 09:04
@ilonatommy ilonatommy requested a review from maraf July 31, 2024 09:05
This was referenced Jul 31, 2024
Closed
Open
Closed
@ilonatommy ilonatommy merged commit 0ac75cd into dotnet:main Aug 1, 2024
@ilonatommy ilonatommy mentioned this pull request Aug 22, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@maraf maraf Awaiting requested review from maraf

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

javascript calling a method with return Task type in .net 9.0 preview6, the returned promise is always in pending state
2 participants
@ilonatommy @pavelsavara