[main] Update dependencies from dotnet/roslyn-analyzers

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

• Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
• Build: 20240408.3
• Date Produced: April 9, 2024 3:50:07 AM UTC
• Commit: 7455f63411369a962f769361d1a979a547756ada
• Branch: refs/heads/main

• Updates:
  • Microsoft.CodeAnalysis.Analyzers: from 3.11.0-beta1.24177.1 to 3.11.0-beta1.24208.3
  • Microsoft.CodeAnalysis.NetAnalyzers: from 9.0.0-preview.24177.1 to 9.0.0-preview.24208.3

[stephentoub]

@MihaZupan, @buyaa-n, the recent SearchValues analyzer changes are causing a crash, eg

error AD0001: Analyzer 'Microsoft.NetCore.CSharp.Analyzers.Performance.CSharpUseSearchValuesAnalyzer' threw an exception of type 'System.ArgumentException' with message 'Syntax node is not within syntax tree'. 

[MihaZupan]

Scanning through the changes in dotnet/roslyn-analyzers#7252 again nothing immediately stands out to me, I'll try to debug it on runtime locally

It's choking up on this line

runtime/src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs

Line 555 in 7def0b7

int lastIdx = pathNameBytes.LastIndexOfAny(PathInternal.Utf8DirectorySeparators);

[MihaZupan]

Created dotnet/roslyn-analyzers#7279 that fixes this build, but I don't understand why it's needed (see PR description).

[ericstj]

The one remaining failure from Build Analysis is a build failure:

error : Work item System.Text.RegularExpressions.Tests in job ac703041-e9f2-4478-9a58-f9b8e42fcd95 has failed.

However this is just a cascading error from the test which was already excused with #100715

[ericstj]

/ba-g not flipping status of SendToHelix step in build, reluctant to create a known issue as this could be too broad.