-
Notifications
You must be signed in to change notification settings - Fork 4.2k
WIP (not for review): Create BoundBadExpression instead of BoundCall for erroneous invocations #80216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AlekseyTs
wants to merge
1
commit into
dotnet:main
Choose a base branch
from
AlekseyTs:Issue78433_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocations There are 52 known test failures in C# compiler tests: ``` Test Class: OutVarTests Failed Stale (3) Project: Microsoft.CodeAnalysis.CSharp.Emit3.UnitTests (net9.0) Failed Stale (10) Namespace: Microsoft.CodeAnalysis.CSharp.UnitTests Failed Stale (5) Class: DiagnosticAnalyzerTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.DiagnosticAnalyzerTests.TestOperationConstructorBlockCallbackOnInvalidBaseCall Failed Stale Class: FlowDiagnosticTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.FlowDiagnosticTests.RegressionTest949324 Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.OutVarTests.DiagnosticsDifferenceBetweenLanguageVersions_01 Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.OutVarTests.OutVarDiscardInCtor_02 Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.OutVarTests.VarIsNotVar_02 Failed Stale Namespace: Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics Failed Stale (5) Class: ExtensionTests Failed Stale (4) Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.ExtensionTests.ExtensionMemberLookup_InterpolationHandler_AppendFormattedExtensionMethod Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.ExtensionTests.ExtensionMemberLookup_InterpolationHandler_AppendFormattedExtensionTypeMethod Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.ExtensionTests.ExtensionMemberLookup_InterpolationHandler_AppendLiteralExtensionDeclarationMethod Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.ExtensionTests.ExtensionMemberLookup_InterpolationHandler_AppendLiteralExtensionMethod Failed Stale Class: RefReadonlyParameterTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.RefReadonlyParameterTests.RefReadonlyParameter_Ctor_OutArgument Failed Stale Project: Microsoft.CodeAnalysis.CSharp.IOperation.UnitTests (net9.0) Failed Stale (21) Namespace: Microsoft.CodeAnalysis.CSharp.UnitTests Failed Stale (21) Class: IOperationTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests.NullInPlaceOfParamArray Failed Stale Class: IOperationTests_IArgument Failed Stale (3) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IArgument.ExtraArgument Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IArgument.TestOmittedArgument Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IArgument.WrongArgumentType Failed Stale Class: IOperationTests_IConstructorBodyOperation Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IConstructorBodyOperation.ConstructorBody_19 Failed Stale Class: IOperationTests_IDeclarationExpression Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IDeclarationExpression.DeclarationFlow_01 Failed Stale Class: IOperationTests_IDefaultValueOperation Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IDefaultValueOperation.DefaultValueFlow_03 Failed Stale Class: IOperationTests_IInterpolatedStringExpression Failed Stale (4) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IInterpolatedStringExpression.InterpolatedStringExpression_EmptyInterpolationPart(hasDefaultHandler: True) Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IInterpolatedStringExpression.InterpolatedStringExpression_InvalidExpressionInInterpolation(hasDefaultHandler: True) Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IInterpolatedStringExpression.InterpolatedStringHandlerConversion_05 Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IInterpolatedStringExpression.InterpolatedStringHandlerConversion_07 Failed Stale Class: IOperationTests_InvalidExpression Failed Stale (4) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_InvalidExpression.BuildsArgumentsOperationsForDuplicateExplicitArguments_CorrectArgumentsOrder_Methods Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_InvalidExpression.BuildsArgumentsOperationsForDuplicateExplicitArguments_IncorrectArgumentsOrder_Methods Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_InvalidExpression.InvalidInvocationExpression_OverloadResolutionFailureBadArgument Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_InvalidExpression.InvalidInvocationExpression_OverloadResolutionFailureExtraArgument Failed Stale Class: IOperationTests_IObjectCreationExpression Failed Stale (4) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IObjectCreationExpression.ImplicitObjectCreationCollectionInitializerStaticAddMethod Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IObjectCreationExpression.ImplicitObjectCreationCollectionInitializerWithRefAddMethod Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IObjectCreationExpression.ObjectCreationCollectionInitializerStaticAddMethod Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IObjectCreationExpression.ObjectCreationCollectionInitializerWithRefAddMethod Failed Stale Class: IOperationTests_IThrowOperation Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_IThrowOperation.ThrowFlow_13 Failed Stale Class: IOperationTests_StackAllocArrayCreationAndInitializer Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.IOperationTests_StackAllocArrayCreationAndInitializer.StackAllocArrayCreationErrorCase_InvocationExpressionAsDimension Failed Stale Project: Microsoft.CodeAnalysis.CSharp.Semantic.UnitTests (net472) Failed Stale (12) Namespace: Microsoft.CodeAnalysis.CSharp.UnitTests Failed Stale (5) Class: DelegateTypeTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.DelegateTypeTests.TypeInference_03 Failed Stale Class: FunctionPointerTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.FunctionPointerTests.FunctionPointerInferenceInReturn Failed Stale Class: LocalFunctionTests Failed Stale (2) Microsoft.CodeAnalysis.CSharp.UnitTests.LocalFunctionTests.ConstraintBinding2 Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.LocalFunctionTests.ParameterScope_NotInTypeConstraint Failed Stale Class: UnsafeTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.UnsafeTests.FixingVariables_TypeParameters2 Failed Stale Namespace: Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics Failed Stale (7) Class: BindingTests Failed Stale (2) Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.BindingTests.NonMethodsWithArgs Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.BindingTests.NonViableDelegates Failed Stale Class: InterpolationTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.InterpolationTests.MissingAppendMethods Failed Stale Class: NullableReferenceTypesTests Failed Stale (4) Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.NullableReferenceTypesTests.Lambda_21 Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.NullableReferenceTypesTests.MemberNotNull_NonStaticLocalFunction_MissingArgument Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.NullableReferenceTypesTests.NullableBaseMembers Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Semantics.NullableReferenceTypesTests.TypeInference_LowerBounds_NestedNullability_Pointers Failed Stale Project: Microsoft.CodeAnalysis.CSharp.Symbol.UnitTests (net472) Failed Stale (9) Namespace: Microsoft.CodeAnalysis.CSharp.UnitTests Failed Stale (3) Class: NullablePublicAPITests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.NullablePublicAPITests.LambdaInBadExpression Failed Stale Class: SemanticModelGetSemanticInfoTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.SemanticModelGetSemanticInfoTests.GenericExtensionMethodCall Failed Stale Class: SemanticTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.SemanticTests.UnmanagedConstraintOnExtensionMethod Failed Stale Namespace: Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols Failed Stale (6) Class: ExtensionMethodTests Failed Stale (1) Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.ExtensionMethodTests.InaccessibleInstanceMember Failed Stale Class: RequiredMembersTests Failed Stale (5) Test Group: Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.RequiredMembersTests.ForbidRequiredAsNew_Inheritance Failed Stale (2) Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.RequiredMembersTests.ForbidRequiredAsNew_Inheritance(useMetadataReference: False) Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.RequiredMembersTests.ForbidRequiredAsNew_Inheritance(useMetadataReference: True) Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.RequiredMembersTests.ForbidRequiredAsNew_MalformedMembersList Failed Stale Test Group: Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.RequiredMembersTests.ForbidRequiredAsNew_NoInheritance Failed Stale (2) Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.RequiredMembersTests.ForbidRequiredAsNew_NoInheritance(typeKind: "class") Failed Stale Microsoft.CodeAnalysis.CSharp.UnitTests.Symbols.RequiredMembersTests.ForbidRequiredAsNew_NoInheritance(typeKind: "struct") Failed Stale ```
There are 31 known non-IOperation test failures in C# compiler tests:
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 52 known test failures in C# compiler tests: