Further cleanup of the code action api (5) #80215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
CyrusNajmabadi
commented
Sep 11, 2025
| namespace Microsoft.CodeAnalysis.Editor.Implementation.Suggestions; | ||
|
|
||
| internal partial class SuggestedActionWithNestedFlavors | ||
| internal sealed partial class SuggestedActionWithNestedFlavors |
There was a problem hiding this comment.
Folded CodeRefactoring suggested actions and CodeFix suggested actions into this common type.
CyrusNajmabadi
commented
Sep 11, 2025
| /// <summary> | ||
| /// Represents light bulb menu item for code fixes. | ||
| /// </summary> | ||
| internal sealed class CodeFixSuggestedAction( |
There was a problem hiding this comment.
Folded into the base type.
CyrusNajmabadi
commented
Sep 11, 2025
| /// <summary> | ||
| /// Represents light bulb menu item for code refactorings. | ||
| /// </summary> | ||
| internal sealed class CodeRefactoringSuggestedAction( |
There was a problem hiding this comment.
Folded into the base type.
CyrusNajmabadi
commented
Sep 11, 2025
| FixAllState state => new FixAllCodeAction(state), | ||
| RefactorAllState state => new RefactorAllCodeAction(state), | ||
| _ => throw ExceptionUtilities.UnexpectedValue(fixAllState) | ||
| }), |
There was a problem hiding this comment.
note: this typeswitching goes away and gets nice in a later PR in this series.
CyrusNajmabadi
commented
Sep 11, 2025
| diagnosticTelemetryId: null, | ||
| new RefactorAllCodeRefactoringCodeAction(fixAllCodeRefactoringAction.FixAllState)), | ||
| refactorOrFixAllAction.FixAllState, refactorOrFixAllAction.OriginalCodeAction, refactorOrFixAllAction.TelemetryId), | ||
| UnifiedSuggestedActionWithNestedActions nestedAction => new SuggestedActionWithNestedActions( |
There was a problem hiding this comment.
this code will collapse even further in following PRs.
CyrusNajmabadi
commented
Sep 11, 2025
| /// Fix all code action for a code action registered by a <see cref="CodeRefactoringProvider"/>. | ||
| /// </summary> | ||
| internal sealed class RefactorAllCodeRefactoringCodeAction(IRefactorOrFixAllState fixAllState) | ||
| internal sealed class RefactorAllCodeAction(IRefactorOrFixAllState fixAllState) |
There was a problem hiding this comment.
named this akin to FixAllCodeAction.
NOte: a following PR merges those into one RefactorOrFixAllCodeAction.
|
@JoeRobich ptal. :) |
JoeRobich
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.