Skip to content

Optimize for single capture case #12569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize for single capture case #12569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Build/Evaluation/ExpressionShredder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ public bool MoveNext()
int endQuoted = currentIndex - 1;
if (transformExpressions == null)
{
transformExpressions = new List<ItemExpressionCapture>();
// PERF: Almost all expressions have only one capture, so optimize for that case
transformExpressions = new List<ItemExpressionCapture>(1);
}

transformExpressions.Add(new ItemExpressionCapture(startQuoted, endQuoted - startQuoted, expression.Substring(startQuoted, endQuoted - startQuoted)));
Expand All @@ -192,7 +193,8 @@ public bool MoveNext()
{
if (transformExpressions == null)
{
transformExpressions = new List<ItemExpressionCapture>();
// PERF: Almost all expressions have only one capture, so optimize for that case
transformExpressions = new List<ItemExpressionCapture>(1);
}

transformExpressions.Add(functionCapture.Value);
Expand Down
Loading