This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update usage of StartNew/ContinueWith in tests #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searched through tests for usage of StartNew and ContinueWith. - Replaced StartNew calls with Task.Run when the parameters to StartNew were all the defaults used by Task.Run or where no scheduler was specified but should have been. (I also changed one or two places to use Task.Run where LongRunning had been specified, but where using LongRunning with the default scheduler would have resulted in thousands of threads getting created). - Ensured remaining StartNew and ContinueWith calls were all targeting TaskScheduler.Default explicitly.
|
LGTM. |
|
I'll merge this and then merge v1 to master. Lots of goodnes in v1 today. |
nguerrera
added a commit
that referenced
this pull request
Jan 30, 2015
Update usage of StartNew/ContinueWith in tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searched through tests for usage of StartNew and ContinueWith.