[Blazor][HotReload] Capture the execution context before calling RenderRootComponentsOnHotReload #63846
+90
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where AsyncLocal values were being lost during hot reload operations in Blazor applications. The core problem was that hot reload callbacks executed without the original ExecutionContext, causing AsyncLocal-backed data (culture, logging scopes, circuit state) to disappear after hot reload.
- Captures the ExecutionContext when subscribing to hot reload events during root component registration
- Creates a helper class to restore the captured context when invoking hot reload re-renders
- Adds a regression test that confirms AsyncLocal values survive hot reload operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Components/Components/src/RenderTree/Renderer.cs | Implements ExecutionContext capture and restoration for hot reload callbacks |
| src/Components/Components/test/RendererTest.cs | Adds regression test to verify AsyncLocal values are preserved during hot reload |
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/aspnetcore/actions/runs/18044715064 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure ExecutionContext flows to hot reload re-renders
Description
ExecutionContextwhen subscribing toHotReloadManager.OnDeltaAppliedRenderRootComponentsOnHotReloadvia a helper that restores the captured context, preserving AsyncLocal valuesFixes #45741
Customer Impact
AsyncLocal-backed data (e.g., culture, logging scopes, circuit state) was being lost after hot reload, leading to incorrect behavior on subsequent renders.
Regression?
Risk
Changes are scoped to the hot reload subscription path, reuse existing render logic, and are exercised by automated tests.
Verification
Packaging changes reviewed?