-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Avoid having to update PreReleaseBrandingLabel for each release #63799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid having to update PreReleaseBrandingLabel for each release #63799
Conversation
@copilot Please continue. |
Co-authored-by: mmitche <[email protected]>
I've implemented the automatic calculation of PreReleaseBrandingLabel as requested. The implementation uses MSBuild conditional properties in eng/Versions.props to calculate the branding label based on PreReleaseVersionLabel:
All test cases pass and the current repository state (rc → "RC 1") continues to work correctly. I also updated the documentation to reflect that PreReleaseBrandingLabel no longer needs manual updates. Commit: 366cc88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR automates the calculation of PreReleaseBrandingLabel
based on PreReleaseVersionLabel
to simplify the release process by eliminating manual updates.
- Replaces manual
PreReleaseBrandingLabel
setting with conditional MSBuild properties - Updates documentation to reflect the automated process
- Implements mapping for all five release types (alpha, preview, rc, rtm, servicing)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
eng/Versions.props | Adds conditional MSBuild properties to automatically calculate PreReleaseBrandingLabel based on PreReleaseVersionLabel |
docs/UpdatingMajorVersionAndTFM.md | Updates documentation to remove manual PreReleaseBrandingLabel update step |
Implements automatic calculation of
PreReleaseBrandingLabel
based onPreReleaseVersionLabel
to simplify the release process.Original issue description:
Changes Made
eng/Versions.props
: Replaced manualPreReleaseBrandingLabel
setting with automatic conditional calculation using MSBuild propertiesdocs/UpdatingMajorVersionAndTFM.md
to remove the manual step for updatingPreReleaseBrandingLabel
Implementation Details
The new implementation uses MSBuild conditional properties to automatically calculate
PreReleaseBrandingLabel
:alpha
→ "Alpha $(PreReleaseVersionIteration)"preview
→ "Preview $(PreReleaseVersionIteration)"rc
→ "RC $(PreReleaseVersionIteration)"rtm
→ "RTM"servicing
→ "Servicing"Benefits
PreReleaseVersionIteration
andPreReleaseVersionLabel
Testing
Fixes #63798
Fixes #63798
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.