[release/10.0] Implement KnownNetworks dual list #63658

sebastienros · 2025-09-12T16:02:51Z

Description

This PR is introducing a new property and obsoleting another. They both represent the same concept and are both used in the codebase. However users will only be able to update the new one, and clearing it won't affect the previous one which is still used throughout the code.

This PR adds tests to ensure that the expected behavior is not broken when using a single property. The previous tests were manipulating both, which users can't do. They successfully raise failing tests.
It's then adding a new collection that will back the two properties, such that altering either property will have the same effect (share collection).

Fixes #63627

Customer Impact

Http Overrides features is broken, failing customers app during auth.

Regression?

Yes
No

In 10.0-rc1

Risk

High
Medium
Low

The other option is to revert the obsoletion of the previous property described in this announcement

Verification

Manual (required)
Automated

sebastienros · 2025-09-12T16:03:08Z

/cc @WeihanLi

Copilot

Pull Request Overview

This PR implements a dual-list system for managing known networks in ForwardedHeadersOptions to ensure compatibility between the new KnownIPNetworks property and the obsolete KnownNetworks property. The changes ensure that modifications to either property are reflected in both, addressing issue #63627 where clearing one property didn't affect the other.

Key Changes

Introduces a new DualIPNetworkList class that synchronizes changes between both property types
Updates ForwardedHeadersOptions to use the dual-list as backing storage for both properties
Adds comprehensive tests to verify the synchronization behavior works correctly

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`src/Middleware/HttpOverrides/src/DualIPNetworkList.cs`	New dual-list implementation that maintains sync between System.Net.IPNetwork and obsolete AspNet IPNetwork types
`src/Middleware/HttpOverrides/src/ForwardedHeadersOptions.cs`	Updates to use the dual-list as backing storage for both KnownIPNetworks and KnownNetworks properties
`src/Middleware/HttpOverrides/src/ForwardedHeadersMiddleware.cs`	Simplifies known IP checking logic by removing redundant obsolete collection checks
`src/Middleware/HttpOverrides/test/ForwardedHeadersMiddlewareTest.cs`	Adds new test variants to verify behavior when using only the new property API
`src/Middleware/HttpOverrides/test/DualIPNetworkListTests.cs`	New test file covering dual-list synchronization scenarios
`src/DefaultBuilder/src/ForwardedHeadersOptionsSetup.cs`	Removes redundant clearing of obsolete property since dual-list keeps them in sync

Fixes #63627

src/Middleware/HttpOverrides/src/ForwardedHeadersMiddleware.cs

joperezr

Left a minor question but this LGTM, thanks a bunch @sebastienros.

@danmoseley FYI this needs approval for RC2 merge. (fixing a regression introduced after one of the obsoletions we did in P7)

danmoseley · 2025-09-15T23:05:40Z

Fixing regression - approved.

sebastienros · 2025-09-16T19:53:23Z

Summoning @wtgodbe or @captainsafia for your merging powers

sebastienros · 2025-09-16T19:53:57Z

/backport to main

github-actions · 2025-09-16T19:54:04Z

Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/17777371720

sebastienros · 2025-09-16T19:55:40Z

I created a PR for main but if we expect to merge release/10.0 to main soon then it's useless.

WeihanLi · 2025-09-17T08:12:56Z

I created a PR for main but if we expect to merge release/10.0 to main soon then it's useless.

Would the obsolete members be removed on .NET 11? Maybe no need to backport if we plan to remove in the next Major version.

* [release/10.0] Implement KnownNetworks dual list (#63658) * Refactor unit tests to handle the obsolete property * Implement KnownNetworks dual list Fixes #63627 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250908.1 (#63679) On relative base path root optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime From Version 1.0.0-prerelease.25453.1 -> To Version 1.0.0-prerelease.25458.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update `Microsoft.Identity.Web` dependencies (#63705) Co-authored-by: Mackinnon Buck <[email protected]> * Update dependencies from https://github.com/dotnet/dotnet build 283666 (#63712) Updated Dependencies: Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 10.0.0-rc.2.25466.101 -> 10.0.0-rc.2.25467.107) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 10.0.0-beta.25466.101 -> 10.0.0-beta.25467.107) Microsoft.Web.Xdt (Version 3.2.0-preview.25466.101 -> 3.2.0-preview.25467.107) NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.0.0-preview.2.46701 -> 7.0.0-preview.2.46807) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [release/10.0] Fix ComponentStatePersistenceManager iteration to prevent AntiforgeryValidationException in Blazor WASM (#63694) * Initial plan * Fix ComponentStatePersistenceManager to iterate backwards in InferRenderModes Co-authored-by: javiercn <[email protected]> * Add unit test for ComponentStatePersistenceManager callback removal during iteration Co-authored-by: javiercn <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: javiercn <[email protected]> * [release/10.0] [Blazor] Clear RootTypeCache cache on HotReload (#63653) * Clear RootTypeCache cache on HotReload * ClearCache method * Fix --------- Co-authored-by: Marek Fišera <[email protected]> * Resolve conflicts (#63711) * [release/10.0] Fix Validation source generator deployment for non-Web SDKs (#63715) * Proof-of-concept fix for getting validation SG to work in Blazor Wasm SDK projects * Use special type symbol for missing type comparisons --------- Co-authored-by: Ondřej Roztočil <[email protected]> * [release/10.0] Enable spectre mitigations for ANCM binaries (#63728) * Enable spectre mitigations for ANCM binaries * Set property as well * Revert "Set property as well" This reverts commit b573d8a. --------- Co-authored-by: wtgodbe <[email protected]> * Update dependencies from https://github.com/dotnet/dotnet build 283828 (#63732) Updated Dependencies: Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 10.0.0-rc.2.25467.107 -> 10.0.0-rc.2.25468.104) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 10.0.0-beta.25467.107 -> 10.0.0-beta.25468.104) Microsoft.Web.Xdt (Version 3.2.0-preview.25467.107 -> 3.2.0-preview.25468.104) NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.0.0-preview.2.46807 -> 7.0.0-preview.2.46904) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/extensions build 20250912.1 (#63681) On relative base path root Microsoft.Extensions.Caching.Hybrid , Microsoft.Extensions.Diagnostics.Testing , Microsoft.Extensions.TimeProvider.Testing From Version 9.10.0-preview.1.25456.3 -> To Version 9.10.0-preview.1.25462.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> --------- Co-authored-by: Sébastien Ros <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mackinnon Buck <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: javiercn <[email protected]> Co-authored-by: Marek Fišera <[email protected]> Co-authored-by: William Godbe <[email protected]> Co-authored-by: Ondřej Roztočil <[email protected]>

Refactor unit tests to handle the obsolete property

1cc1447

Copilot AI review requested due to automatic review settings September 12, 2025 16:02

sebastienros requested review from BrennanConroy and halter73 as code owners September 12, 2025 16:02

Copilot AI reviewed Sep 12, 2025

View reviewed changes

sebastienros mentioned this pull request Sep 12, 2025

Changing KnownNetworks.Clear() to KnownIPNetworks.Clear() breaks forwarded headers #63627

Closed

sebastienros added the Servicing-consider Shiproom approval is required for the issue label Sep 12, 2025

sebastienros changed the title ~~Implement KnownNetworks dual list~~ [release/10.0] Implement KnownNetworks dual list Sep 12, 2025

build-analysis bot mentioned this pull request Sep 12, 2025

[Known Build Error] NavigationException_InAsyncContext_DoesNotBecomeUnobservedTaskException fails with ObjectDisposedException #62672

Open

sebastienros force-pushed the sebros/knownnetworks branch from f39e804 to 85c47be Compare September 12, 2025 19:33

sebastienros requested a review from joperezr September 12, 2025 22:00

Implement KnownNetworks dual list

f590099

Fixes #63627

sebastienros force-pushed the sebros/knownnetworks branch from 85c47be to f590099 Compare September 12, 2025 22:57

joperezr reviewed Sep 13, 2025

View reviewed changes

src/Middleware/HttpOverrides/src/ForwardedHeadersMiddleware.cs Show resolved Hide resolved

joperezr approved these changes Sep 13, 2025

View reviewed changes

WeihanLi approved these changes Sep 13, 2025

View reviewed changes

danmoseley linked an issue Sep 15, 2025 that may be closed by this pull request

Changing KnownNetworks.Clear() to KnownIPNetworks.Clear() breaks forwarded headers #63627

Closed

danmoseley added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 15, 2025

captainsafia approved these changes Sep 16, 2025

View reviewed changes

github-actions bot mentioned this pull request Sep 16, 2025

Implement KnownNetworks dual list #63697

Closed

11 tasks

joperezr merged commit 72692ad into release/10.0 Sep 17, 2025
28 checks passed

joperezr deleted the sebros/knownnetworks branch September 17, 2025 16:43

dotnet-policy-service bot added this to the 10.0-rc2 milestone Sep 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release/10.0] Implement KnownNetworks dual list #63658

[release/10.0] Implement KnownNetworks dual list #63658

Uh oh!

sebastienros commented Sep 12, 2025 •

edited

Loading

Uh oh!

sebastienros commented Sep 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

joperezr left a comment

Uh oh!

danmoseley commented Sep 15, 2025

Uh oh!

sebastienros commented Sep 16, 2025

Uh oh!

sebastienros commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

sebastienros commented Sep 16, 2025

Uh oh!

WeihanLi commented Sep 17, 2025

Uh oh!

Uh oh!

Uh oh!

[release/10.0] Implement KnownNetworks dual list #63658

[release/10.0] Implement KnownNetworks dual list #63658

Uh oh!

Conversation

sebastienros commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Customer Impact

Regression?

Risk

Verification

Uh oh!

sebastienros commented Sep 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

joperezr left a comment

Choose a reason for hiding this comment

Uh oh!

danmoseley commented Sep 15, 2025

Uh oh!

sebastienros commented Sep 16, 2025

Uh oh!

sebastienros commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

sebastienros commented Sep 16, 2025

Uh oh!

WeihanLi commented Sep 17, 2025

Uh oh!

Uh oh!

Uh oh!

sebastienros commented Sep 12, 2025 •

edited

Loading