Don't reference System.ValueTuple on netstandard2.0 #63240
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed there and will raise a NuGet package pruning warning
There was a problem hiding this comment.
Pull Request Overview
This PR refines the conditional reference to System.ValueTuple package to only target .NET Framework projects, removing it from .NET Standard 2.0 where it's not needed and causes NuGet package pruning warnings.
- Updated conditional reference logic for
System.ValueTuplepackage - Changed from excluding .NET Core App to explicitly including only .NET Framework
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Microsoft.AspNetCore.InternalTesting.csproj | Modified System.ValueTuple reference condition to target only .NET Framework |
| Microsoft.Extensions.Logging.AzureAppServices.csproj | Modified System.ValueTuple reference condition to target only .NET Framework |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
github-actions
bot
added
the
needs-area-label
ViktorHofer
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed there and will raise a NuGet package pruning warning