[Blazor] Always treat "preloads" as new elements when doing enhanced navigation #63239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents incorrect asset preloading during Blazor enhanced navigation by treating preload elements as new elements that should be replaced rather than updated. The change addresses a browser behavior where modifying existing preload elements can trigger downloading of incorrect assets depending on the order of attribute updates.
- Introduces logic to always treat preload elements as new during DOM diffing
- Adds helper function to identify preload elements based on tag name and rel attribute
javiercn
approved these changes
Aug 13, 2025
This was referenced Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once
rel="preload"appears on element, browser eagerly starts to download the file. If we modify existing element, it may happen, based on the order of attributes, that we trigger preloading incorrect asset.