[Blazor] Implement property analyzer for [PersistentState] attribute #63236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new analyzer
PersistentStateAnalyzer
that applies the same property initializer validation rules to[PersistentState]
properties as the existingSupplyParameterFromFormAnalyzer
does for[SupplyParameterFromForm]
properties.Problem
Properties decorated with
[PersistentState]
that have non-default property initializers can have their values overwritten during parameter binding, similar to the issue that already exists with[SupplyParameterFromForm]
properties. This can lead to unexpected behavior where the initial value is lost.Solution
The new
PersistentStateAnalyzer
(diagnostic ID: BL0009) warns developers when they use property initializers with non-default values on[PersistentState]
properties:Implementation Details
The implementation follows the exact same pattern as
SupplyParameterFromFormAnalyzer
:PersistentStateAttribute
support toComponentSymbols
,ComponentFacts
, andComponentsApi
PersistentStateAnalyzer.cs
with the same logic as the existing form analyzerValidation
Fixes #63235.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.