Skip to content

[Blazor] Use DynamicDependency to preserve KeyValuePair for WebAssembly trimming #63099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 7, 2025
Merged

[Blazor] Use DynamicDependency to preserve KeyValuePair for WebAssembly trimming #63099

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
56cfccb
Initial plan
Copilot Aug 4, 2025
e41281a
Add ILLink.Descriptors.xml to Components.WebAssembly project
Copilot Aug 4, 2025
fc94643
Replace ILLink.Descriptors.xml with DynamicDependency attribute for K…
Copilot Aug 4, 2025
5a2f695
Move DynamicDependency to public method and use typeof instead of har…
Copilot Aug 4, 2025
f7f1da9
Use DynamicallyAccessedMemberTypes.PublicConstructors instead of All …
Copilot Aug 4, 2025
ba95337
Move DynamicDependency for KeyValuePair to private constructor
Copilot Aug 4, 2025
4c78ccd
Update src/Components/WebAssembly/WebAssembly/src/Microsoft.AspNetCor…
javiercn Aug 5, 2025
2cf9e04
Use LinkerFlags.JsonSerialized for KeyValuePair DynamicDependency
Copilot Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...Components/WebAssembly/WebAssembly/src/Microsoft.AspNetCore.Components.WebAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,6 @@
<ItemGroup>
<InternalsVisibleTo Include="DynamicProxyGenAssembly2" Key="$(MoqPublicKey)" />
</ItemGroup>


</Project>
1 change: 1 addition & 0 deletions src/Components/WebAssembly/WebAssembly/src/Services/DefaultWebAssemblyJSRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ internal sealed partial class DefaultWebAssemblyJSRuntime : WebAssemblyJSRuntime
[DynamicDependency(nameof(BeginInvokeDotNet))]
[DynamicDependency(nameof(ReceiveByteArrayFromJS))]
[DynamicDependency(nameof(UpdateRootComponentsCore))]
[DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors, typeof(KeyValuePair<,>))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Use LinkerFlags.JsonSerialized

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to use LinkerFlags.JsonSerialized for consistency with other JSON-serialized types in the same file. Commit: 2cf9e04

private DefaultWebAssemblyJSRuntime()
{
ElementReferenceContext = new WebElementReferenceContext(this);
Expand Down
Loading