-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add passkey count and name length limits #62979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds limits to passkey management in the Blazor Web App project template by restricting passkey name length to 200 characters and limiting accounts to a maximum of 100 passkeys.
- Adds a
MaxLength
validation attribute to enforce 200-character limit on passkey names - Implements a maximum of 100 passkeys per account with both UI and server-side validation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
RenamePasskey.razor | Adds name length validation with 200-character limit |
Passkeys.razor | Implements passkey count limit with UI controls and server-side validation |
...es/content/BlazorWeb-CSharp/BlazorWebCSharp.1/Components/Account/Pages/Manage/Passkeys.razor
Show resolved
Hide resolved
...ntent/BlazorWeb-CSharp/BlazorWebCSharp.1/Components/Account/Pages/Manage/RenamePasskey.razor
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Changes in this PR:
ResidentKeyRequirement
to "preferred" so that security keys supporting resident keys register a client-side discoverable credential when possible/
instead of\\
to fix a bug when creating the project template on macOS.Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3709
Fixes https://github.com/dotnet/aspnetcore-manualtests/issues/3699
Fixes #60807