Skip to content

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Jul 28, 2025

Changes in this PR:

  • Updates the Blazor Web App project template to enforce limits on passkey name length and the number of passkeys that can be registered to an account
  • Changes the default value of ResidentKeyRequirement to "preferred" so that security keys supporting resident keys register a client-side discoverable credential when possible
  • Updates the sqlite connection string to use a / instead of \\ to fix a bug when creating the project template on macOS.

Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3709
Fixes https://github.com/dotnet/aspnetcore-manualtests/issues/3699
Fixes #60807

@Copilot Copilot AI review requested due to automatic review settings July 28, 2025 19:37
@github-actions github-actions bot added the area-blazor Includes: Blazor, Razor Components label Jul 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds limits to passkey management in the Blazor Web App project template by restricting passkey name length to 200 characters and limiting accounts to a maximum of 100 passkeys.

  • Adds a MaxLength validation attribute to enforce 200-character limit on passkey names
  • Implements a maximum of 100 passkeys per account with both UI and server-side validation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
RenamePasskey.razor Adds name length validation with 200-character limit
Passkeys.razor Implements passkey count limit with UI controls and server-side validation

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Aug 4, 2025
@MackinnonBuck
Copy link
Member Author

/azp run

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Aug 5, 2025
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@MackinnonBuck MackinnonBuck merged commit 3c4f3ec into main Aug 11, 2025
29 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/passkeys-limits branch August 11, 2025 17:43
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-rc1 milestone Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor template with individual auth breaks on windows (Data\app.db?)
2 participants