Skip RequestPathBase_WithDoubleSlashes_Split for now #62931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
requested review from
halter73,
BrennanConroy and
JamesNK
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily skips a failing test RequestPathBase_WithDoubleSlashes_Split due to IIS feature rollback on the test machines. The test will be re-enabled after the next deployment restores the required IIS features.
Comments suppressed due to low confidence (1)
src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestPathBaseTests.cs:73
- The
[SkipOnCI]attribute completely disables test coverage for this functionality in CI environments. Consider using a more specific attribute like[SkipOnPlatform]or[ConditionalFact]with environment checks to only skip when the required IIS features are unavailable, ensuring the test runs when conditions are met.
[SkipOnCI]
github-actions
bot
added
the
area-networking
wtgodbe
added a commit
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing after the machine rollback yesterday - this is due to us losing some IIS features that were added in the rollout last week. It should only fail until the next rollout next week, at which time I'll revert this change.