Skip to content

Conversation

natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Nov 13, 2018

Changes:

  • Generate 2.2.0 package baselines
  • Update dependencies to 2.2.0
  • Update branding to 2.2.1-servicing

Depends on aspnet/Templating#832

@natemcmaster natemcmaster requested review from Eilon and muratg November 13, 2018 21:55
Copy link
Contributor

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost too simple 😄

@natemcmaster
Copy link
Contributor Author

FYI @jkotalik

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in the ItemGroup below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression there were changes in IISIntegration in 2.2.1. If that's not true, then yes, this should be reverted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What needs to change to make this use the global version.props file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change similar to this: #4013

This can't happen yet because we don't have all of IISIntegration's dependencies merged into the mondo repo.

Copy link
Contributor

@jkotalik jkotalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as things pass.

* Generate 2.2.0 package baselines
* Update dependencies to 2.2.0
* Update branding to 2.2.1-servicing
@natemcmaster natemcmaster merged commit a8ec75a into release/2.2 Nov 14, 2018
@natemcmaster natemcmaster deleted the namc/2.2.1 branch November 14, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants