-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Prepare for the 2.2.1 patch #4015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost too simple 😄
FYI @jkotalik |
build/submodules.props
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in the ItemGroup below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression there were changes in IISIntegration in 2.2.1. If that's not true, then yes, this should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
src/IISIntegration/version.props
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What needs to change to make this use the global version.props file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A change similar to this: #4013
This can't happen yet because we don't have all of IISIntegration's dependencies merged into the mondo repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as things pass.
* Generate 2.2.0 package baselines * Update dependencies to 2.2.0 * Update branding to 2.2.1-servicing
58949a5
to
a8ec75a
Compare
Changes:
Depends on aspnet/Templating#832