Skip to content

Implement Http/2 CompleteAsync #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2019
Merged

Implement Http/2 CompleteAsync #11193

merged 4 commits into from
Jun 15, 2019

Conversation

Tratcher
Copy link
Member

#10886 Adding IHttpResponseCompletionFeature.CompleteAsync for HTTP/2 only.

  • Allows for the graceful completion of a response message (from the client's perspective) without waiting for the request delegate to unwind.
  • It makes sure all remaining response headers, data, and trailers are sent before it returns.
  • It may throw if the response is in an invalid state such as a Content-Length mismatch.
  • RequestAborted will not fire after this completes. Abort can still be used though.

Retrofitting this for HTTP/1.1 shouldn't be hard but I wanted to unblock the gRPC scenarios first.

While testing this I fixed a bug in response trailers where they were not getting cleared if the app threw an exception and the server converted it to a 500 response. You'd end up with a 500 + trailers.

@Tratcher Tratcher added this to the 3.0.0-preview7 milestone Jun 13, 2019
@Tratcher Tratcher requested review from JamesNK and halter73 June 13, 2019 21:29
@Tratcher Tratcher self-assigned this Jun 13, 2019
halter73
halter73 reviewed Jun 13, 2019
View reviewed changes
@Tratcher Tratcher mentioned this pull request Jun 13, 2019
Closed
@Tratcher Tratcher mentioned this pull request Jun 13, 2019
Closed
@Tratcher Tratcher requested a review from halter73 June 13, 2019 22:39
@Tratcher Tratcher force-pushed the tratcher/complete branch from c41294b to 8ca6917 Compare June 14, 2019 22:12
@Tratcher Tratcher merged commit bc5bee7 into master Jun 15, 2019
@Tratcher Tratcher deleted the tratcher/complete branch June 15, 2019 16:01
@analogrelay analogrelay mentioned this pull request Jun 18, 2019
Closed
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@JamesNK JamesNK JamesNK approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

+1 more reviewer

@jkotalik jkotalik jkotalik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging this pull request may close these issues.
5 participants
@Tratcher @halter73 @JamesNK @jkotalik @amcasey