-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Closed
Labels
affected-fewThis issue impacts only small number of customersThis issue impacts only small number of customersarea-mvcIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesenhancementThis issue represents an ask for new feature or an enhancement to an existing oneThis issue represents an ask for new feature or an enhancement to an existing onefeature-mvc-testingMVC testing packageMVC testing packagegood first issueGood for newcomers.Good for newcomers.help wantedUp for grabs. We would accept a PR to help resolve this issueUp for grabs. We would accept a PR to help resolve this issueseverity-minorThis label is used by an internal toolThis label is used by an internal tool
Milestone
Description
We currently only implement Dispose and call Wait()
on the host StopAsync()
within Dispose
.
Ideally we want to avoid this and simply implement IAsyncDisposable with IDisposable just being a fallback for it.
The only issue here is that currently the factory can be use as an xUnit fixture out of the box, but unfortunately I believe xUnit doesn't support IAsyncDisposable in addition to IDisposable, since they have their own interface for it (IAsyncLifetime).
This means that for using IAsyncDisposable users will either have to extend the default factory and make it implement IAsyncLifetime or create the factory within the test method and use an await using
statement to dispose of it.
aayjaychan
Metadata
Metadata
Assignees
Labels
affected-fewThis issue impacts only small number of customersThis issue impacts only small number of customersarea-mvcIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesenhancementThis issue represents an ask for new feature or an enhancement to an existing oneThis issue represents an ask for new feature or an enhancement to an existing onefeature-mvc-testingMVC testing packageMVC testing packagegood first issueGood for newcomers.Good for newcomers.help wantedUp for grabs. We would accept a PR to help resolve this issueUp for grabs. We would accept a PR to help resolve this issueseverity-minorThis label is used by an internal toolThis label is used by an internal tool