1709 list item structure #1710
1709 list item structure #1710
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). widget-test-docs – ./🔍 Inspect: https://vercel.com/dojo/widget-test-docs/EYyzdnsyvfPEyWRTmgbvrFNJmugs dojo.widgets – ./🔍 Inspect: https://vercel.com/dojo/dojo.widgets/74fyTdUpkKX6KQt2HSggavsNXwGL |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1710 +/- ##
==========================================
- Coverage 90.07% 89.95% -0.12%
==========================================
Files 94 94
Lines 5047 5059 +12
Branches 1375 1377 +2
==========================================
+ Hits 4546 4551 +5
- Misses 249 254 +5
- Partials 252 254 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| let listContents: RenderResult; | ||
|
|
||
| if (isRenderResult(firstChild)) { | ||
| listContents = firstChild; |
There was a problem hiding this comment.
Since it is only taking the first child, users of the widget will need to wrap the content in a <virtual> element. Should this pass all the children so it could be used like the following?
<ListItem>
Text node
<span>sibling node</span>
</ListItem>
| case 'small': | ||
| paddingClass = themedCss.smallPadding; | ||
| break; | ||
| case 'medium': |
There was a problem hiding this comment.
Should the options be 'small' and 'large'?
There was a problem hiding this comment.
could always add a large too, but that's fine by me
| composes: mdc-list-item from '@material/list/dist/mdc.list.css'; | ||
| } | ||
|
|
||
| .smallPadding { |
There was a problem hiding this comment.
What does this padding default to?
| padding-right: calc(var(--mdc-theme-grid-base) * 2); | ||
| } | ||
|
|
||
| .noPadding { |
There was a problem hiding this comment.
Can you avoid !important by adding .root to the selector?
There was a problem hiding this comment.
most likely, could be that material css is using a gnarly selector though
Type: bug / feature
The following has been addressed in the PR:
.dojorctheme.variant()is added to the root domnodetheme.composelike thisDescription:
primaryspan if typed children are used, this allows for full-width content to be passed.paddingproperty with specified sizes toListItemto allow the padding to be easily reduced or increased.Resolves #1709