Update minimum cmake required #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
approved these changes
May 12, 2025
snnn
added a commit
to microsoft/onnxruntime
that referenced
this pull request
May 14, 2025
To include the following change: dmlc/dlpack#165
adrianlizarraga
pushed a commit
to microsoft/onnxruntime
that referenced
this pull request
Aug 5, 2025
To include the following change: dmlc/dlpack#165
adrianlizarraga
pushed a commit
to microsoft/onnxruntime
that referenced
this pull request
Aug 5, 2025
To include the following change: dmlc/dlpack#165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the minimum required version of CMake. This change is necessary because the CMake 4.0 release removed policies that allowed supporting such old versions of CMake, so having such a low required minimum version of CMake prohibits using the latest versions. CMake 3.16 is already quite old (the release was back in 2019) and it is a reasonable choice based on Linux distro support (for example, it is the supported version for Ubuntu's 20.04 LTS release).
Resolves #162